← Back to team overview

deja-dup-team team mailing list archive

[Merge] lp:~daniel-muller/deja-dup/deja-dup into lp:deja-dup

 

Daniel Muller has proposed merging lp:~daniel-muller/deja-dup/deja-dup into lp:deja-dup.

Requested reviews:
  Déjà Dup Developers (deja-dup-hackers)

For more details, see:
https://code.launchpad.net/~daniel-muller/deja-dup/deja-dup/+merge/219094

Added S3 Reduced Redundancy Storage (RRS), allowing to close wishlist 811954.
Passing --s3-use-rrs to duplicity.
No GUI. The boolean option is read from dconf setting (defaulting to false).

First time I do this. So not sure I did everything right.
-- 
https://code.launchpad.net/~daniel-muller/deja-dup/deja-dup/+merge/219094
Your team Déjà Dup Developers is requested to review the proposed merge of lp:~daniel-muller/deja-dup/deja-dup into lp:deja-dup.
=== modified file 'libdeja/BackendS3.vala'
--- libdeja/BackendS3.vala	2012-10-25 16:00:23 +0000
+++ libdeja/BackendS3.vala	2014-05-10 10:34:21 +0000
@@ -25,6 +25,7 @@
 public const string S3_ID_KEY = "id";
 public const string S3_BUCKET_KEY = "bucket";
 public const string S3_FOLDER_KEY = "folder";
+public const string S3_RRS_KEY = "rrs";
 
 const string S3_SERVER = "s3.amazonaws.com";
 
@@ -38,9 +39,15 @@
     return new BackendS3();
   }
   
+  bool settings_rrs;
   public override void add_argv(ToolJob.Mode mode, ref List<string> argv) {
     if (mode == ToolJob.Mode.INVALID)
       argv.append("--s3-use-new-style");
+
+    var settings = get_settings(S3_ROOT);
+    settings_rrs = settings.get_boolean(S3_RRS_KEY);
+    if (settings_rrs) 
+      argv.append("--s3-use-rrs");
   }
   
   string get_default_bucket() {


Follow ups