← Back to team overview

deja-dup-team team mailing list archive

[Merge] lp:~laney/deja-dup/gsettings-settings-id-property into lp:deja-dup

 

Iain Lane has proposed merging lp:~laney/deja-dup/gsettings-settings-id-property into lp:deja-dup.

Requested reviews:
  Déjà Dup Developers (deja-dup-hackers)

For more details, see:
https://code.launchpad.net/~laney/deja-dup/gsettings-settings-id-property/+merge/227338

glib removed the deprecated 'settings' property on GSettings with 2.41.2 that I just uploaded to Utopic. Looks like deja-dup was still using it.

  https://git.gnome.org/browse/glib/commit/?id=cf9b162e0d0defaff2ad5c85aeaf7af0899ad22f

If you like this branch, could you upload it to Utopic or let me know if I can?
-- 
https://code.launchpad.net/~laney/deja-dup/gsettings-settings-id-property/+merge/227338
Your team Déjà Dup Developers is requested to review the proposed merge of lp:~laney/deja-dup/gsettings-settings-id-property into lp:deja-dup.
=== modified file 'libdeja/FilteredSettings.vala'
--- libdeja/FilteredSettings.vala	2013-01-27 21:50:59 +0000
+++ libdeja/FilteredSettings.vala	2014-07-18 14:23:52 +0000
@@ -37,7 +37,7 @@
 
   public FilteredSettings(string schema, bool ro)
   {
-    Object(schema: schema, read_only: ro);
+    Object(schema_id: schema, read_only: ro);
   }
 
   public new void apply() {if (!read_only) base.apply();}


Follow ups