← Back to team overview

deja-dup-team team mailing list archive

[Merge] lp:~skaistis/deja-dup/GnomeStatusIconFix into lp:deja-dup

 

Jeff Skaistis has proposed merging lp:~skaistis/deja-dup/GnomeStatusIconFix into lp:deja-dup.

Requested reviews:
  Déjà Dup Developers (deja-dup-hackers)

For more details, see:
https://code.launchpad.net/~skaistis/deja-dup/GnomeStatusIconFix/+merge/275707

Under Gnome Shell, clicking the dd status icon for a completed, but errored, backup would attempt to open a new dd instance instead of displaying the error window. The existing dd instance would remain in the background and prevent any further backups until it was manually killed. This one-liner just makes sure that the error window can be displayed and dismissed properly.
-- 
Your team Déjà Dup Developers is requested to review the proposed merge of lp:~skaistis/deja-dup/GnomeStatusIconFix into lp:deja-dup.
=== modified file 'deja-dup/StatusIcon.vala'
--- deja-dup/StatusIcon.vala	2013-10-10 05:55:33 +0000
+++ deja-dup/StatusIcon.vala	2015-10-26 14:32:03 +0000
@@ -127,7 +127,8 @@
       string more = null;
       if (detail != null) {
         msg = _("Backup finished");
-        more = _("Not all files were successfully backed up.  See dialog for more details.");
+        more = _("Not all files were successfully backed up.  See dialog for more details."); 
+        show_window();
       }
 
       Notify.init(_("Backups"));


Follow ups