deja-dup-team team mailing list archive

[Martin Wimpress <martin.wimpress@xxxxxxxxxxxxx>]

Martin Wimpress has proposed merging lp:~flexiondotorg/deja-dup/deja-dup-lp1623835 into lp:deja-dup.

Requested reviews:
  Déjà Dup Developers (deja-dup-hackers)
Related bugs:
  Bug #1623835 in deja-dup (Ubuntu): "Updated gtk element means you need to specify a size on the details drop down or it is only 1 line high"
  https://bugs.launchpad.net/ubuntu/+source/deja-dup/+bug/1623835

For more details, see:
https://code.launchpad.net/~flexiondotorg/deja-dup/deja-dup-lp1623835/+merge/310523

Set a minimum content height of 200px for the progress scrolled window. This was the default height used in deja-dup with GTK versions prior to 3.20. (LP: #1623835)

-- 
Your team Déjà Dup Developers is requested to review the proposed merge of lp:~flexiondotorg/deja-dup/deja-dup-lp1623835 into lp:deja-dup.

=== modified file 'deja-dup/AssistantOperation.vala'
--- deja-dup/AssistantOperation.vala	2015-11-05 18:20:28 +0000
+++ deja-dup/AssistantOperation.vala	2016-11-10 12:29:13 +0000
@@ -254,7 +254,8 @@
     progress_scroll.set("child", progress_text,
                         "hscrollbar-policy", Gtk.PolicyType.AUTOMATIC,
                         "vscrollbar-policy", Gtk.PolicyType.AUTOMATIC,
-                        "border-width", 0);
+                        "border-width", 0,
+                        "min-content-height", 200);
     progress_expander = new Gtk.Expander.with_mnemonic(_("_Details"));
     progress_expander.set("child", progress_scroll);
     progress_expander.expand = true;