desktop-packages team mailing list archive

[Chow Loong Jin <hyperair@xxxxxxxxxx>]

On 28/08/2011 17:10, Percherie wrote:
> That I did, thanks to this bug report I discovered this function in
> gconf-editor
> 
> I manage to change the keyboard shortcuts that already exists but I can not add new shortcuts on the "delete from disk". I have an error beep.
> I invite you to take a test at home.
> 
> I use Ubuntu Maverick with Banshee 2.0.1
> 

Alright, I think I see what's wrong in the code. Some ActionEntry objects in
TrackAction.cs are created with null accelerators instead of an empty string.
One of the objects that are created with an empty string for an accelerator is
"Remove from library", and you'll notice that although it comes with no default
shortcut, you can set it to something else.

All this belongs in a different bug of course, rather than this one. I'll file
it and subscribe you.

For the record, here's a patch that should fix your issue (but not this
particular bug). Thanks for helping me track this down.

-- 
Kind regards,
Loong Jin


** Patch added: "0001-Use-instead-of-null-for-empty-accels.patch"
   https://bugs.launchpad.net/bugs/766399/+attachment/2326683/+files/0001-Use-instead-of-null-for-empty-accels.patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to banshee in Ubuntu.
https://bugs.launchpad.net/bugs/766399

Title:
  No option to change banshee keyboard shortcuts

Status in “banshee” package in Ubuntu:
  Invalid

Bug description:
  Binary package hint: banshee

  This is on Natty Beta 2.

  There is no-where in banshee where one can change it's keyboard short-cuts, such as pressing 'f ' making it go full-screen.
  This is incredibly annoying, here is a user-case:

  Sam generally searches through lists by simply typing the first
  letters of whatever he is searching for, as using ubuntu has shown him
  how useful this functionality is, and the fact that most applications
  in ubuntu, such as nautilus, support this kind of searching means that
  Sam expects Banshee to behave in such a consistent manner.

  Because Sam has a lot of artists, to search for the one labelled "Daft
  Punk", he clicks on one of the artists and types "Daft". However,
  pressing f makes banshee go full-screen, which is unexpected, as is
  the fact that searching through the artists list behaves in an
  inconsistent way. Sam knows that he will probably make this mistake
  again, so he searches for an option to remove all keyboard short-cuts
  without a prefix like "Super" or "Control" or "FX", but he is
  incredibly annoyed at not finding any way to disable this
  functionality, and therefore switches to another music player.

  There is nothing more annoying than something that should be
  configurable but isn't. (And editing GConf doesn't count.)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/766399/+subscriptions