← Back to team overview

desktop-packages team mailing list archive

[Bug 1340067] Re: Drop 20_add_alt_screen_toggle_ui.patch - it does nothing with vte3 >= 0.34.9

 

I'm not against fixing it at all, but ... if you take a look around
either here among launchpad bugs (both gnome-terminal and vte/vte3) or
mainstream bugzilla and git, you'll find quite a few way more important
issues, including crash scenarios with known fixes - yet there's no
activity and willingness from anyone backporting them to Trusty or
Utopic.  It's really strange to see discussing the possibility of
releasing a fix for one of the least important bugs while ignoring the
others.  I mean, there's a checkbox that doesn't do anything, and you're
worried about this but not the segfaults?  C'mon...  As long as there
are unfixed crashes, putting any amount of work in backporting the
removal of a nonfunctional checkbox is IMO precious engineering time not
well spent, and yet another update is probably more annoying to the
users than useful.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-terminal in Ubuntu.
https://bugs.launchpad.net/bugs/1340067

Title:
  Drop 20_add_alt_screen_toggle_ui.patch - it does nothing with vte3 >=
  0.34.9

Status in gnome-terminal package in Ubuntu:
  Fix Released
Status in gnome-terminal source package in Trusty:
  New
Status in gnome-terminal source package in Utopic:
  New

Bug description:
  On 2013-09-30, the alternate scroll mode has been implemented in vte3
  upstream [1]. In the same commit,
  vte_terminal_set_alternate_screen_scroll function has been added which
  does nothing and is there only for the compatibility with the
  previously patched Ubuntu's vte3 (the patch has been dropped in vte3
  0.34.9-1ubuntu1).

  Since this function now does nothing, Ubuntu's
  20_add_alt_screen_toggle_ui.patch for gnome-terminal does nothing too.
  It doesn't matter whether you turn the alt.scroll on or off in gnome-
  terminal's preferences window - the mouse scroll in console apps like
  man is ALWAYS turned on. Seems like it's always turned on in vte3 >=
  0.34.9 (again, see [1] for more info).

  So I propose to drop this 20_add_alt_screen_toggle_ui.patch since it's
  useless now.

  [1]
  https://git.gnome.org/browse/vte/commit/?id=9f8c1b88dcd880c2d9e78c93521ee755560a9275

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-terminal/+bug/1340067/+subscriptions