← Back to team overview

desktop-packages team mailing list archive

[Bug 1190344] Re: lightdm is leaking FDs -fix

 

** Description changed:

  [Impact]
- LightDM doesn't close the server side end of the pipes used to communicate with session processes. This means each session that is created leaks two file descriptors eventually leading to the system stopping it from creating new pipes.
+ LightDM doesn't close the server side end of the pipes used to communicate with session processes and greeters. This means each session/greeter that is created leaks two file descriptors eventually leading to the system stopping it from creating new pipes.
  
  [Test Case]
  1. Start LightDM
  2. Check how many pipes are open
  # lsof -p {lightdm_pid} | grep FIFO | wc -l
  3. Create sessions by either cycling between users in Unity Greeter or logging in and out
  4. Check how many pipes exist using step 2.
  Expected result:
  No more pipes should be open
  Observed result:
  Many pipes remain open
  
  [Regression Potential]
  Low. Fix is to close pipes when finished with them. Tested with regression tests.

** Summary changed:

- lightdm is leaking FDs -fix
+ Daemon end of session/greeter pipes not closed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to lightdm in Ubuntu.
https://bugs.launchpad.net/bugs/1190344

Title:
  Daemon end of session/greeter pipes not closed

Status in Light Display Manager:
  Fix Committed
Status in Light Display Manager 1.10 series:
  Fix Committed
Status in Light Display Manager 1.12 series:
  Fix Committed
Status in Light Display Manager 1.2 series:
  Fix Committed
Status in lightdm package in Ubuntu:
  Triaged
Status in lightdm source package in Precise:
  Triaged
Status in lightdm source package in Trusty:
  Triaged
Status in lightdm source package in Utopic:
  Triaged
Status in lightdm source package in Vivid:
  Triaged
Status in Fedora:
  Unknown

Bug description:
  [Impact]
  LightDM doesn't close the server side end of the pipes used to communicate with session processes and greeters. This means each session/greeter that is created leaks two file descriptors eventually leading to the system stopping it from creating new pipes.

  [Test Case]
  1. Start LightDM
  2. Check how many pipes are open
  # lsof -p {lightdm_pid} | grep FIFO | wc -l
  3. Create sessions by either cycling between users in Unity Greeter or logging in and out
  4. Check how many pipes exist using step 2.
  Expected result:
  No more pipes should be open
  Observed result:
  Many pipes remain open

  [Regression Potential]
  Low. Fix is to close pipes when finished with them. Tested with regression tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/lightdm/+bug/1190344/+subscriptions