desktop-packages team mailing list archive

[Ehsan-mozilla <584632@xxxxxxxxxxxxxxxxxx>]

Comment on attachment 8584608
Unified patch (code + test changes + three times revised new test)

Review of attachment 8584608:
-----------------------------------------------------------------

Can you please revise the commit message to explain what the patch does?
Something like: "Bug 756984 - Collapse the selection on the last text
node on the line, skipping br and inline frames when clicking past the
end of line; r=roc,ehsan".

Thanks again!  Once you address these nits, this is ready to be checked
in.

::: layout/generic/test/test_bug756984.html
@@ +43,5 @@
> +        is(selRange.endContainer.nodeName, "#text", "selection should be in text node");
> +        is(selRange.endOffset, 3, "offset should be 3");
> +      }
> +
> +      // click beyond the second line (100px to the left and 2px down), expect DIV.

Nit: please make this "first line".

@@ +47,5 @@
> +      // click beyond the second line (100px to the left and 2px down), expect DIV.
> +      // This is the previous behaviour which hasn't changed since the line is empty.
> +      // If the processing were wrong, the selection would end up in the preceing non-empty line.
> +      theDiv = document.getElementById("div4");
> +      sel = window.getSelection();

Nit: this is not needed.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/584632

Title:
  composer changes font mid email

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in thunderbird package in Ubuntu:
  Confirmed

Bug description:
  Binary package hint: thunderbird

  As I'm typing my emails in Thunderbird, I can see what appears to be a
  font size change on screen, normally in the second line of text. The
  second line appear smaller than the first. It's barely perceptible, so
  half them time I think I am imagining it.

  Well, I've started Bccing to myself to check, and the emails I am
  receiving from myself are not only a different size, they're also a
  different font. Composer starts in some default serif, and by the
  second line is sans. I'd bee glad to email someone viz thunderbird,
  and also send along a screenshot of how it looks while I am typing.

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/584632/+subscriptions