← Back to team overview

desktop-packages team mailing list archive

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

 

I have made a fix for this bug and attached it as a debdiff to this
comment:

This is a very simple change to the code in debian/gdm.init - I remove
line 73 which has an extra unmatched "fi"

Tested as follows:
Built binaries using sbuild in latest vivid environment on a trusty machine.  Fired up an Ubuntu-Gnome vivid daily build (current for 4/2/2015) LiveCD in a virtual machine.  Verified the bug failure on the plain vanilla vivid LiveCD as follows:

cd /etc/init.d
./gdm

Could not get the failure with "./gdm start" like mentioned in the bug
report - had to leave out "start"

Copied all the .deb files from the vivid sbuild on the trusty machine
onto the Ubuntu-Gnome vivid vm.  Installed the four .deb files using
"dpkg -i ..."  Install succeeded, and visually inspecting
/etc/init.d/gdm showed line 73 was indeed removed.  Typed:

cd /etc/init.d
./gdm

At the command prompt and got no error about "fi" - just showed the
informational message about usage (because I left out "start").  This
confirms that the bug is fixed for the current version of vivid.

** Patch added: "Fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome vivid"
   https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

Status in Ubuntu GNOME:
  New
Status in gdm package in Ubuntu:
  Confirmed
Status in gdm source package in Trusty:
  Confirmed

Bug description:
  Ubuntu release 14.04 LTS
  gdm 3.10.0.1-0ubuntu3

  I just tried to start gdm with "/etc/init.d/gdm start " and got the
  message:

  /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: "fi" unexpected
  (expecting "}")

  I'm aware of service(8) but cjwatson said I should report this as a
  bug anyway!

  Owen

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions