← Back to team overview

desktop-packages team mailing list archive

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

 

I have made a fix (patch) for this bug for utopic, tested on Ubuntu-
Gnome utopic and attached it as gdm_3.10.0.1-0ubuntu7.2.debdiff to this
comment:

This is a very simple change to the code in debian/gdm.init - I removed
line 78 which has an extra unmatched "fi"

Tested as follows:
Built binaries using sbuild in latest utopic environment on a trusty machine. Fired up an Ubuntu-Gnome utopic 14.10 release build LiveCD in a virtual machine. Verified the bug failure on the plain vanilla utopic LiveCD as follows:

/etc/init.d/gdm
(gave syntax error)

If I changed directories to /etc/init.d and did "./gdm" the script did
not do anything - just returned.  Also, "/etc/init.d/gdm start" worked
fine.  Still, the error did occur as indicated above.

Copied all the .deb files from the utopic sbuild on the trusty build
machine onto the Ubuntu-Gnome utopic livecd vm. Installed the four .deb
files using "dpkg -i ..." Install succeeded, and visually inspecting
/etc/init.d/gdm showed original line 78 was indeed removed. Typed:

/etc/init.d/gdm
(worked as expected - no syntax error)
/etc/init.d/gdm start
(worked as expected - no syntax error)

This confirms that the bug fix works for the 14.10 utopic release
version of Ubuntu-Gnome.

** Patch removed: "vivid fix for LP: #1315442 - removed line 73 (extra "fi") - tested on Ubuntu-Gnome vivid"
   https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

Status in Ubuntu GNOME:
  New
Status in gdm package in Ubuntu:
  Confirmed
Status in gdm source package in Trusty:
  Confirmed
Status in gdm source package in Utopic:
  New

Bug description:
  Ubuntu release 14.04 LTS
  gdm 3.10.0.1-0ubuntu3

  I just tried to start gdm with "/etc/init.d/gdm start " and got the
  message:

  /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: "fi" unexpected
  (expecting "}")

  I'm aware of service(8) but cjwatson said I should report this as a
  bug anyway!

  Owen

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions