← Back to team overview

desktop-packages team mailing list archive

[Bug 1442596] Re: Delete only deletes content of a page, not the page itself

 

** Description changed:

- Hello,
+ [Impact]
+ Attempting to delete a page in a two page document replaces deleted page with a blank page leaving two pages.
  
- I forward a bug from Debian:
+ [Test Case]
+ 1. Open Simple Scan
+ 2. Scan two pages
+ 3. Delete a page
  
- [quote]
- Dear Maintainer,
+ Expected result:
+ Selected page is deleted and one page remains.
  
- I scanned two pages of a document. I didn't want to keep the second
- page.
+ Observed result:
+ Selected page is replaced with a blank page and two pages remain.
  
- I right-clicked on the page I didn't want and selected Delete.
- 
- Only the content of the second page was deleted not the page itself, so I was
- still left with a two-page document, the second page of which was blank.
- 
- I expected the page to be deleted.
- 
- Cheers, Fraz
- [/quote]
+ [Regression Potential]
+ Low. The change in revision 701 caused the blank page adding logic to run after the page was removed not before it. This meant it had an off-by-one error when checking if a blank page should be added.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to simple-scan in Ubuntu.
https://bugs.launchpad.net/bugs/1442596

Title:
  Delete only deletes content of a page, not the page itself

Status in Simple Scan:
  Fix Committed
Status in Simple Scan 3.14 series:
  Fix Committed
Status in Simple Scan 3.16 series:
  Fix Committed
Status in simple-scan package in Ubuntu:
  Triaged
Status in simple-scan source package in Utopic:
  Triaged
Status in simple-scan source package in Vivid:
  Triaged
Status in simple-scan package in Debian:
  Confirmed

Bug description:
  [Impact]
  Attempting to delete a page in a two page document replaces deleted page with a blank page leaving two pages.

  [Test Case]
  1. Open Simple Scan
  2. Scan two pages
  3. Delete a page

  Expected result:
  Selected page is deleted and one page remains.

  Observed result:
  Selected page is replaced with a blank page and two pages remain.

  [Regression Potential]
  Low. The change in revision 701 caused the blank page adding logic to run after the page was removed not before it. This meant it had an off-by-one error when checking if a blank page should be added.

To manage notifications about this bug go to:
https://bugs.launchpad.net/simple-scan/+bug/1442596/+subscriptions