desktop-packages team mailing list archive
-
desktop-packages team
-
Mailing list archive
-
Message #112922
[Bug 1280110] Re: Compilation warning in bamf-application.c because of implicit cast of try_create_local_desktop_data return value
Fix Released in bamf BAMF 0.5.1 "The Trusty BAMF".
** Changed in: bamf
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to bamf in Ubuntu.
https://bugs.launchpad.net/bugs/1280110
Title:
Compilation warning in bamf-application.c because of implicit cast of
try_create_local_desktop_data return value
Status in BAMF Application Matching Framework:
Fix Released
Status in bamf package in Ubuntu:
Fix Released
Bug description:
try_create_local_desktop_data contains an invocation of the
g_return_val_if_fail macro, which in case of failure returns NULL
instead of a gboolean value (the return type signature of the try_...
function).
This is wrong on two different counts:
- implicit cast warning, which when warnings are treated as errors cause compilation failure
- if NULL is explicitly cast to gboolean, it yields another error as a pointer has differing size as a gboolean (even though in this case it's all-zero)
The correct fix is to have g_return_val_if_fail return FALSE instead
of NULL.
To manage notifications about this bug go to:
https://bugs.launchpad.net/bamf/+bug/1280110/+subscriptions