desktop-packages team mailing list archive

[Monsta <1340687@xxxxxxxxxxxxxxxxxx>]

[Impact]

The current alternate scroll patch is flawed because the terminal apps
using GTK+2 version of VTE library should also be patched in order for
the alternate scroll to work. This means that mate-terminal, roxterm-
gtk2, lxterminal (and other terminal apps that aren't patched in all
Ubuntu releases) don't have the alternate scroll enabled.

The proposed new patch that's contained in the debdiffs makes alternate
scroll work always, so no patching will be required for any terminal
apps.

So, the old patch should be replaced with the new one in all current
stable releases of Ubuntu.

[Test Case]

Steps to reproduce:
1. Run mate-terminal or any other non-patched terminal app using GTK+2 version of VTE library.
2. Run "man apt-get" (any other manpage will work too of course).
3. See that scrolling with mouse wheel doesn't work on the manpage.

[Regression Potential]

After almost a year of testing the patch in various stable releases of Ubuntu, I found no regressions.
I consider the regression risk to be very low here.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to vte in Ubuntu.
https://bugs.launchpad.net/bugs/1340687

Title:
  Please replace current alternate screen scroll patch with the new one,
  making this scroll permanent

Status in vte package in Ubuntu:
  Confirmed

Bug description:
  Dear maintainers,

  Please remove 93_add_alt_screen_scroll_toggle.patch and replace it
  with the new patch from the attachment.

  This patch adds support for DEC 1007 escape sequence, thus making the
  alternate screen scroll work always. After applying it, the
  corresponding patches with the calls to
  vte_terminal_set_alternate_screen_scroll function can be safely
  dropped from the terminal applications using GTK2-based vte (e.g.
  xfce4-terminal).

  The patch has been adapted from the upstream commit in VTE3 [1].

  [1]
  https://git.gnome.org/browse/vte/commit/?id=9f8c1b88dcd880c2d9e78c93521ee755560a9275

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/vte/+bug/1340687/+subscriptions