← Back to team overview

desktop-packages team mailing list archive

[Bug 1220629] Re: xmir_screen_for_each_damaged_window iterates through all outputs on every frame (including unused ones)

 

** No longer affects: xmir

** Tags added: xmir

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xorg-server in Ubuntu.
https://bugs.launchpad.net/bugs/1220629

Title:
  xmir_screen_for_each_damaged_window iterates through all outputs on
  every frame (including unused ones)

Status in xorg-server package in Ubuntu:
  New

Bug description:
  xmir_screen_for_each_damaged_window iterates through all outputs
  (including unused ones), on every frame.

  I thought it was a bit odd when debugging
  xmir_screen_for_each_damaged_window that it iterated through 6-8
  different xmir_window's. I only have two outputs plugged in. The
  number actually grew over time (with display config changes?).

  I think we should avoid iterating (or even creating) unused
  xmir_windows. In the very least it's inefficient to process all the
  damage reports more times than necessary.

  Furthermore, I suspect the unused xmir_windows are accumulating damage
  that never gets emptied, which is probably bad.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1220629/+subscriptions