← Back to team overview

desktop-packages team mailing list archive

[Bug 567574] Re: gdm greeter crashes because of incorrect XKB variant handling

 

lucid has seen the end of its life and is no longer receiving any
updates. Marking the lucid task for this ticket as "Won't Fix".

** Changed in: gdm (Ubuntu Lucid)
       Status: Triaged => Won't Fix

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/567574

Title:
  gdm greeter crashes because of incorrect XKB variant handling

Status in gdm package in Ubuntu:
  Triaged
Status in gdm source package in Lucid:
  Won't Fix

Bug description:
  There is a patch in ubuntu:
  +From ca4d405b1087c30a1bd764937dbc0b66b0473032 Mon Sep 17 00:00:00 2001
  +From: Martin Pitt <martin.pitt@xxxxxxxxxx>
  +Date: Tue, 23 Mar 2010 12:47:59 +0100
  +Subject: [PATCH 2/2] Keep multiple system keyboard layouts for session
  This patch contains one serious bug:
  ++                config->layouts = g_new0 (char *, g_strv_length (initial_config->layouts) + 2);
  ++                config->variants = g_new0 (char *, g_strv_length (initial_config->variants) + 2);
  In case you have 2 layouts and variants are not specified (I got that scenario), you will allocate 4 and 2 elements correspondingly. This is clearly wrong - because later you'll assign 3 variants. Then gdm-greeter crashes inside xklavier (memory corruption).

  The correct code should have
   config->variants = g_new0 (char *, g_strv_length (initial_config->layouts) + 2);

  This is gdm crasher, so please fix it ASAP.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/567574/+subscriptions