desktop-packages team mailing list archive

Thread
Date

[Bug 572391] Re: 01Pulseaudio does nothing due to misuse of su -l and shell misquoting

To: desktop-packages@xxxxxxxxxxxxxxxxxxx
From: Rolf Leggewie <572391@xxxxxxxxxxxxxxxxxx>
Date: Wed, 17 Jun 2015 11:45:58 -0000
Reply-to: Bug 572391 <572391@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

lucid has seen the end of its life and is no longer receiving any
updates. Marking the lucid task for this ticket as "Won't Fix".

** Changed in: pulseaudio (Ubuntu Lucid)
       Status: Fix Committed => Won't Fix

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to pulseaudio in Ubuntu.
https://bugs.launchpad.net/bugs/572391

Title:
  01Pulseaudio does nothing due to misuse of su -l and shell misquoting

Status in pulseaudio package in Ubuntu:
  Fix Released
Status in pulseaudio source package in Lucid:
  Won't Fix

Bug description:
    affects ubuntu/pulseaudio
    status triaged
    assignee hyperair
    importance high
    tag patch regression-release

  PROBLEM:
  These few days, I noticed pulseaudio making weird sounds during and after
  suspending, as well as hanging and wrecking havoc in every sound-using application.

  This is with a kernel with sound-2.6.git merged in, so it's not about broken
  outdated audio drivers.

  REASON:
  01Pulseaudio pm-utils hook script is broken in several places.

  FIX:
  1. Remove -l from all instances of su invocations. -l causes a login shell which
  immediately causes the script to fail silently since all the su invocations go
  to /dev/null.

  2. Fix su quoting.

  Regarding #2, There were several instances of 'blahblah${var}', which was
  intended to sub in ${var}, but obviously wouldn't work because they was not
  exported in the first place. So the patch changes ' to " for these cases.

  Then there are the savestate/restorestate/state_exists shell functions which
  were within the quotes of the command passed to su. This broke the script as well.

  Attached is a patch which combined fixes for all the above issues. Do what you
  will with it. I've tested it, and it works on my system.

  --
  Kind regards,
  Chow Loong Jin

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pulseaudio/+bug/572391/+subscriptions