desktop-packages team mailing list archive

[Chris J Arges <1461082@xxxxxxxxxxxxxxxxxx>]

Hello Monsta, or anyone else affected,

Accepted gtksourceview2 into vivid-proposed. The package will build now
and be available at
https://launchpad.net/ubuntu/+source/gtksourceview2/2.10.5-2ubuntu1.1 in
a few hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: gtksourceview2 (Ubuntu Vivid)
       Status: In Progress => Fix Committed

** Changed in: gtksourceview2 (Ubuntu Trusty)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gtksourceview2 in Ubuntu.
https://bugs.launchpad.net/bugs/1461082

Title:
  patch - fix crash with long one-line XML documents

Status in gtksourceview2 package in Ubuntu:
  Fix Released
Status in gtksourceview2 source package in Precise:
  Fix Committed
Status in gtksourceview2 source package in Trusty:
  Fix Committed
Status in gtksourceview2 source package in Utopic:
  Fix Committed
Status in gtksourceview2 source package in Vivid:
  Fix Committed
Status in gtksourceview2 source package in Wily:
  Fix Released
Status in gtksourceview2 package in Debian:
  Confirmed

Bug description:
  [Impact]

  When editing a long one-line document with some markup (e.g. XML) with
  Pluma (or any other editor using gtksourceview2), you cannot delete a
  selected portion of text because the editor will crash.

  This has been reported upstream and fixed in [1], but the commit never
  made it to GTK+2 version of gtksourceview.

  So, I propose fixing it in current stable Ubuntu releases with the patch which fixes the crash for good.
  The debdiffs for every stable release are in the attachments below.

  
  [Test Case]

  Steps to reproduce:

  1. Open a long one-line XML document (e.g. [2]) with Pluma. Any other editor using gtksourceview2 will also fit I think.
  2. Select a portion of text.
  3. Press Backspace (or Delete) key.
  4. Pluma crashes. The full backtrace is at [3].

  If you're running Pluma from the command-line, you'll notice a warning:
  GtkSourceView-CRITICAL **: Highlighting a single line took too much time, syntax highlighting will be disabled

  That's the key. The library tries to invalidate the region when text
  is deleted and the engine is disabled (i.e. syntax highlighting is
  off).

  
  [Regression Potential]

  After several months of testing the patch in Debian Jessie, I haven't
  noticed any regressions.

  
  [1] https://git.gnome.org/browse/gtksourceview/commit/?id=abef41da8c541c814bf631f69c92e0c431c610ad
  [2] http://pastebin.com/nNdYzFXE
  [3] http://pastebin.com/YgDT0iKh

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gtksourceview2/+bug/1461082/+subscriptions