← Back to team overview

desktop-packages team mailing list archive

[Bug 1482641] [NEW] Lightdm (and GDM) source .profile as bash, indirectly sourcing .bashrc

 

Public bug reported:

The fix for https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/678421
leads to `.profile` being sourced by bash instead of dash. This leads
`.bashrc` being sourced indirectly via .profile. IMHO, `.bashrc` should
not be sourced even *once* in this situation. I suggest that sourcing
.profile actually be done with BASH_VERSION unset:

    BASH_VERSION= . "$CONFIG"

At the very least, a check should be done whether bash is the user's
login shell. It can  be done thus:

    [ "$SHELL" != "/bin/bash" ] && BASH_VERSION=
    . "$CONFIG"

utilizing `$SHELL` given it stores the login shell
(http://unix.stackexchange.com/questions/45458/why-shell-doesnt-change-
when-i-run-new-shell).

** Affects: gdm (Ubuntu)
     Importance: Undecided
         Status: New

** Affects: lightdm (Ubuntu)
     Importance: Undecided
         Status: New

** Also affects: lightdm (Ubuntu)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1482641

Title:
  Lightdm (and GDM) source .profile as bash, indirectly sourcing .bashrc

Status in gdm package in Ubuntu:
  New
Status in lightdm package in Ubuntu:
  New

Bug description:
  The fix for https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/678421
  leads to `.profile` being sourced by bash instead of dash. This leads
  `.bashrc` being sourced indirectly via .profile. IMHO, `.bashrc`
  should not be sourced even *once* in this situation. I suggest that
  sourcing .profile actually be done with BASH_VERSION unset:

      BASH_VERSION= . "$CONFIG"

  At the very least, a check should be done whether bash is the user's
  login shell. It can  be done thus:

      [ "$SHELL" != "/bin/bash" ] && BASH_VERSION=
      . "$CONFIG"

  utilizing `$SHELL` given it stores the login shell
  (http://unix.stackexchange.com/questions/45458/why-shell-doesnt-
  change-when-i-run-new-shell).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1482641/+subscriptions


Follow ups