desktop-packages team mailing list archive

[Albert Astals Cid <albert.astals@xxxxxxxxxxxxx>]

Nice work.

Some small things that need fixing.

the cmake way of using pkgconfig is very simple, see
./cmake/modules/FindGTK.cmake for example

You need to free more Objects, every time you do a get object an object
you have to free it, e.g. in countSignatures you need to free fields, f,
type, obj1

The indentation is a bit broken, i know poppler indentation (2 soft
spaces, 8 hard tabs) is a craaaaazy, but at least it'd be cool if your
own functions were consistent, in validateSignature you mix tabs and
spaces.

Also running valgrind it shows some memory leaks, one example

==27912==    by 0x657248F: CERT_NewTempCertificate (in /usr/lib/x86_64-linux-gnu/libnss3.so)
==27912==    by 0x4F9C4A1: SignatureHandler::CMS_SignedDataCreate(NSSCMSMessageStr*) (SignatureHandler.cc:172)
==27912==    by 0x4F9C561: SignatureHandler::SignatureHandler(unsigned char*, int) (SignatureHandler.cc:122)
==27912==    by 0x4F9383F: PDFDoc::validateSignature(int, bool) (PDFDoc.cc:534)


The file in https://bugs.kde.org/attachment.cgi?id=91442 aborts

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/740506

Title:
  verify digital signatures

Status in Evince:
  Confirmed
Status in Poppler:
  Confirmed
Status in poppler package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: evince

  This is a feature request to verify digital signatures.  I'm receiving more and more digitally signed PDF's and evince already acknowledges them with:
  Signature Not Verified
  Digitally signed by <signer>
  Date:  <time stamp>
  Reason: <reason>
  Location: <location>
  but it would be great if Evince would be integrated into the distro's ca-certificate infrastructure to verify these signatures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/evince/+bug/740506/+subscriptions