← Back to team overview

desktop-packages team mailing list archive

[Bug 1280867] Re: nautilus segfaults in compare_by_display_name()

 

I uploaded this to wily and trusty, please test when asked - we had some
trouble reproducing reliably.

** Description changed:

+ [ Description ]
+ 
+ If a samba share has an empty name, nautilus will crash when you browse
+ to the listing of shares.
+ 
+ [ QA ]
+ 
+ - Be on a setup (or create one) where you tickle https://bugzilla.samba.org/show_bug.cgi?id=10896
+ - Open nautilus, hit ctrl-l, browse to smb://workgroups
+ - Nautilus crashes (or doesn't crash with the fix)
+ 
+ [ Fix ]
+ 
+ Fix nautilus_file_peek_display_name () to not return NULL ever, as some of its
+ callers weren't prepared to handle this.
+ 
+ [ Regression potential ]
+ 
+ Should only change crashes to non-crashes, but maybe a caller I missed
+ handled NULL properly and now will behave weirdly. I grepped the source
+ and didn't find one, though.
+ 
+ [ Original release ]
+ 
  samba, Ubuntu 14.04 (alpha)
  
  ProblemType: Crash
  DistroRelease: Ubuntu 14.04
  Package: nautilus 1:3.10.1-0ubuntu4
  ProcVersionSignature: Ubuntu 3.13.0-8.28-generic 3.13.2
  Uname: Linux 3.13.0-8-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.13.2-0ubuntu4
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Sun Feb 16 22:44:08 2014
  ExecutablePath: /usr/bin/nautilus
  GsettingsChanges: b'org.gnome.nautilus.list-view' b'default-column-order' b"['name', 'size', 'type', 'date_modified', 'date_accessed', 'owner', 'group', 'permissions', 'mime_type', 'where']"
  InstallationDate: Installed on 2014-02-15 (1 days ago)
  InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140214)
  ProcCmdline: nautilus -n
  SegvAnalysis:
-  Segfault happened at: 0x4bef0a:	movzbl (%r12),%ecx
-  PC (0x004bef0a) ok
-  source "(%r12)" (0x00000000) not located in a known VMA region (needed readable region)!
-  destination "%ecx" ok
+  Segfault happened at: 0x4bef0a:	movzbl (%r12),%ecx
+  PC (0x004bef0a) ok
+  source "(%r12)" (0x00000000) not located in a known VMA region (needed readable region)!
+  destination "%ecx" ok
  SegvReason: reading NULL VMA
  Signal: 11
  SourcePackage: nautilus
  StacktraceTop:
-  ?? ()
-  ?? ()
-  ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
-  ?? ()
-  ?? ()
+  ?? ()
+  ?? ()
+  ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
+  ?? ()
+  ?? ()
  Title: nautilus crashed with SIGSEGV
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

** Changed in: nautilus (Ubuntu Trusty)
       Status: Triaged => In Progress

** Changed in: nautilus (Ubuntu Wily)
       Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1280867

Title:
  nautilus segfaults in compare_by_display_name()

Status in Nautilus:
  Fix Released
Status in nautilus package in Ubuntu:
  In Progress
Status in nautilus source package in Trusty:
  In Progress
Status in nautilus source package in Wily:
  In Progress
Status in nautilus package in Fedora:
  Unknown

Bug description:
  [ Description ]

  If a samba share has an empty name, nautilus will crash when you
  browse to the listing of shares.

  [ QA ]

  - Be on a setup (or create one) where you tickle https://bugzilla.samba.org/show_bug.cgi?id=10896
  - Open nautilus, hit ctrl-l, browse to smb://workgroups
  - Nautilus crashes (or doesn't crash with the fix)

  [ Fix ]

  Fix nautilus_file_peek_display_name () to not return NULL ever, as some of its
  callers weren't prepared to handle this.

  [ Regression potential ]

  Should only change crashes to non-crashes, but maybe a caller I missed
  handled NULL properly and now will behave weirdly. I grepped the
  source and didn't find one, though.

  [ Original release ]

  samba, Ubuntu 14.04 (alpha)

  ProblemType: Crash
  DistroRelease: Ubuntu 14.04
  Package: nautilus 1:3.10.1-0ubuntu4
  ProcVersionSignature: Ubuntu 3.13.0-8.28-generic 3.13.2
  Uname: Linux 3.13.0-8-generic x86_64
  NonfreeKernelModules: nvidia
  ApportVersion: 2.13.2-0ubuntu4
  Architecture: amd64
  CurrentDesktop: Unity
  Date: Sun Feb 16 22:44:08 2014
  ExecutablePath: /usr/bin/nautilus
  GsettingsChanges: b'org.gnome.nautilus.list-view' b'default-column-order' b"['name', 'size', 'type', 'date_modified', 'date_accessed', 'owner', 'group', 'permissions', 'mime_type', 'where']"
  InstallationDate: Installed on 2014-02-15 (1 days ago)
  InstallationMedia: Ubuntu 14.04 LTS "Trusty Tahr" - Alpha amd64 (20140214)
  ProcCmdline: nautilus -n
  SegvAnalysis:
   Segfault happened at: 0x4bef0a:	movzbl (%r12),%ecx
   PC (0x004bef0a) ok
   source "(%r12)" (0x00000000) not located in a known VMA region (needed readable region)!
   destination "%ecx" ok
  SegvReason: reading NULL VMA
  Signal: 11
  SourcePackage: nautilus
  StacktraceTop:
   ?? ()
   ?? ()
   ?? () from /lib/x86_64-linux-gnu/libglib-2.0.so.0
   ?? ()
   ?? ()
  Title: nautilus crashed with SIGSEGV
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo

To manage notifications about this bug go to:
https://bugs.launchpad.net/nautilus/+bug/1280867/+subscriptions