desktop-packages team mailing list archive
-
desktop-packages team
-
Mailing list archive
-
Message #148103
[Bug 1511154] Re: xdg-settings set <anything> fails with status 2 because of a small glitch
Attaching a patch with Michał's proposed fix, which works for me. I
think it makes sense to use head -n1, the first Exec entry is likely to
be a good pick -- if anyone adds a funny Exec entry, I'd expect it to
not be the first one.
I've found the same bug through a different path -- I ran execsnoop to
try and figure out what chromium was doing when it complained about not
being the default browser, and it's actually invoking `xdg-settings
check default-web-browser chromium-browser.desktop`, which, in my
environment (identified as gnome3) calls the exact same
desktop_file_to_binary ... function.
** Patch added: "Add head -n1 to grep for Exec inside .desktop file, so the next command doesn't get a multiline input."
https://bugs.launchpad.net/ubuntu/+source/xdg-utils/+bug/1511154/+attachment/4516300/+files/xdg-settings.patch
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xdg-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1511154
Title:
xdg-settings set <anything> fails with status 2 because of a small
glitch
Status in xdg-utils package in Ubuntu:
Confirmed
Bug description:
The first user-facing symptom: Google Chrome stable is correctly set
as the default browser in System Settings / Details / Default
Applications as well as in
update-alternatives --display x-www-browser
yet it keeps complaining about not being a default browser. Clicking
"Make Google Chrome the default browser." on Chrome's settings page
has no response.
The problem is reported here http://askubuntu.com/questions/688779
/google-chrome-stable-keeps-asking-if-it-should-be-set-to-default but
the answer is somewhat wrong.
I have successfully reproduced and debugged the problem. I managed to
establish that it is connected to xdg-utils, namely to /usr/bin/xdg-
settings script.
michal@furia:~$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description: Ubuntu 15.10
Release: 15.10
Codename: wily
michal@furia:~$ xdg-settings get default-web-browser
firefox.desktop
michal@furia:~$ xdg-settings set default-web-browser google-chrome.desktop
michal@furia:~$ echo $?
2
michal@furia:~$ xdg-settings get default-web-browser
firefox.desktop
There is a function in /usr/bin/xdg-settings called
desktop_file_to_binary() and it has a bug. It is slightly different
than the one in the vanilla xdg-utils 1.1.0 rc3. It is implemented in
scripts/xdg-utils-common.in.
See line 65 in xdg-utils-1.1.0~rc3+git20150907/scripts/xdg-utils-
common.in :
command="`grep -E "^Exec(\[[^]=]*])?=" "$file" | cut -d= -f 2- | sed
-e 's/ .*$//'`"
When executed against google-chrome.desktop or firefox.desktop it
results with:
google-chrome-stable
google-chrome-stable
google-chrome-stable
or
firefox
firefox
firefox
respectively.
When passed to `which` and then to `readlink -f` it results with no
path to the actual binary. In the vanilla xdg-utils package (version
1.1.0 rc3) the `sed` part is replaced with `first_word`. An
alternative would be adding `| head -n 1`.
Then we would have only one `google-chrome-stable` or `firefox` which
in turn would result with the actual path to binary resolved correctly
and that would make xdg-settings work fine.
Also, it is possible to set Google Chrome as the default browser via
its preferences and the aforementioned first user-facing symptom is
gone.
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xdg-utils/+bug/1511154/+subscriptions
References