← Back to team overview

desktop-packages team mailing list archive

[Bug 1511735] Re: libnl: fail to bind() netlink sockets

 

Hi,

Thanks for the quick update.  I've applied the 4 patches and built a new
test package with the changes.    The example test does indeed fail on
the current version and passes on the new version as well.

I went looking for any other libnl3 tests we might run to catch any
possible regression that might occur when accepting the patches I looked
at the RH bug you referenced and found another testcase ( used to expose
the issue.  I ran that on the updated package and it passes tests a, b
and c, but not d.

I examined the patch applied and it included more fixes, specifically:

Subject: [PATCH 09/10] socket: clear port when unable to generate local
port

which the 'd' test which attempts to test by allocate more than 1024
local ports.  Should a fix for that also be included?

** Attachment added: "libnl3-test-rh1249158.py"
   https://bugs.launchpad.net/ubuntu/+source/libnl3/+bug/1511735/+attachment/4535202/+files/libnl3-test-rh1249158.py

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libnl3 in Ubuntu.
https://bugs.launchpad.net/bugs/1511735

Title:
  libnl: fail to bind() netlink sockets

Status in libnl3 package in Ubuntu:
  Fix Released
Status in libnl3 source package in Trusty:
  New

Bug description:
  The following upstream patches are needed in order to avoid failures
  when binding a netlink socket:

  1f734a8f892a lib/socket: randomize the generated local port
  http://git.infradead.org/users/tgr/libnl.git/commitdiff/1f734a8f892a

  4dd5fdd0af2c lib/socket: retry generate local port in nl_connect on ADDRINUSE
  http://git.infradead.org/users/tgr/libnl.git/commitdiff/4dd5fdd0af2c

  027157898708 lib/socket: don't fail if no more local ports can be assigned in nl_socket_alloc
  http://git.infradead.org/users/tgr/libnl.git/commitdiff/027157898708

  0fd510b3673f lib/socket: use proper typed constant UINT32_MAX for uint32_t typed port
  http://git.infradead.org/users/tgr/libnl.git/commitdiff/0fd510b3673f

  Without these patches, an application which opens and closes regularly
  netlink sockets can easily fails to bind them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libnl3/+bug/1511735/+subscriptions