desktop-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

Committed with a test case, thank you!

** Project changed: python-distutils-extra => python-distutils-extra
(Ubuntu)

** Changed in: python-distutils-extra (Ubuntu)
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to python-distutils-extra in Ubuntu.
https://bugs.launchpad.net/bugs/1393247

Title:
  Glade *.ui files not recognized due to comment line

Status in python-distutils-extra package in Ubuntu:
  Fix Committed

Bug description:
  Glade 3.18 likes to insert a comment as the second line that upsets
  auto.py. Onboard's package fails to build due to this, unless we
  remember to remove the offending line after every change. Could you
  have a look?

  $ cd onboard
  $ ./setup.py build
  ...
  WARNING: the following files are not recognized by DistUtilsExtra.auto:
    ... many ...
    settings.ui

  
  This fixes it for me:

  *** /tmp/auto.py	2014-11-16 21:03:04.244604628 +0100
  --- /usr/lib/python3/dist-packages/DistUtilsExtra/auto.py	2014-11-16 21:03:26.812605563 +0100
  ***************
  *** 305,310 ****
  --- 305,311 ----
            fd = open(f, 'rb')
            firstlines = fd.readline()
            firstlines += b'\n' + fd.readline()
  +         firstlines += b'\n' + fd.readline()
            fd.close()
            if b'<interface' in firstlines or b'<ui version=' in firstlines:
                src_mark(src, f)

  Ubuntu Vivid
  python3-distutils-extra 2.38-1build1
  glade 3.18.3-1

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/python-distutils-extra/+bug/1393247/+subscriptions