← Back to team overview

desktop-packages team mailing list archive

[Bug 1540811] Re: [GDK] patch - avoid integer overflow when allocating a large block of memory


Thank you for your work. I've sponsored the xenial update (with a
modified changelog, we don't have designed maintainers/NMUs in Ubuntu,
also I tweaked the version number to not be .1 and listed the bug

Once the update gets some testing in xenial we can look at the SRUs

Note that it would be nice to suggest to upstream that they backport the
change to gtk-2-24 since they still roll updates to gtk2 sometimes and
it could benefit users of other distros that way

** Changed in: gtk+2.0 (Ubuntu)
       Status: Triaged => Fix Committed

You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gtk+2.0 in Ubuntu.

  [GDK] patch - avoid integer overflow when allocating a large block of

Status in GTK+:
  Fix Released
Status in gtk+2.0 package in Ubuntu:
  Fix Committed
Status in gtk+2.0 package in Debian:

Bug description:

  Due to a logic error, an attempt to allocate a large block of memory
  fails in gdk_cairo_set_source_pixbuf, leading to a crash of the app
  that called it, for example, eom [1].

  This issue had been fixed [2] in GTK+3, but GTK+2 apps that use the
  mentioned function still crash when trying to allocate a lot of
  memory. An example of such app is eom (Eye of MATE), an image viewer,
  which crashes when trying to load a large image.

  I propose fixing it in current Ubuntu releases with the patch which fixes the crash.
  The debdiffs are in the attachments in the comments below.

  [Test Case]

  Steps to reproduce:

  1. Have a 64-bit installation of Ubuntu.
  2. Install eom if it isn't installed.
  3. Download the archive from the attachment of this post and unpack it. (Firefox doesn't allow me to upload image as is - tries to make thumbnail of it right in the file open dialog, then crashes.)
  4. Open the unpacked image (27000_27000_1437947845.png) in eom.
  5. eom crashes. The full backtrace is at [3].

  You'll also see an error message: "failed to allocate
  18446744072330584320 bytes". This huge number appears due to overflow
  during multiplication of two 32-bit signed integers. In the patch,
  this error is avoided by using a different memory allocation function.

  [Regression Potential]

  After several months of testing the patch in Debian Jessie, Debian
  Testing and Ubuntu 14.04, I haven't noticed any regressions.

  [1] https://github.com/mate-desktop/eom/issues/93
  [2] https://git.gnome.org/browse/gtk+/commit?id=894b1ae76a32720f4bb3d39cf460402e3ce331d6
  [3] https://github.com/mate-desktop/eom/issues/93#issuecomment-141035799

To manage notifications about this bug go to: