desktop-packages team mailing list archive

[Dirk F <1544612@xxxxxxxxxxxxxxxxxx>]

Thanks, Martin.

But, the absence of the enable[d] file is apparently a legitimate case,
and your patch as it stands causes an undesirable error message in the
PM log in that case, such as:

cat: /sys/class/net/wlan0/device/enable*: No such file or directory

Hence my original proposed test for the file's existence.

As an alternative you could have $(cat .... 2>/dev/null) but that would
risk masking a genuine error.

Incidentally, with a fix similar to the one you committed in place, I've
observed that the b43 driver, which gets the default power-save command
(lines 41-2 of wireless script)  currently fails to respect the command,
eg:

# iwconfig wlan0 power on
Error for wireless request "Set Power Management" (8B2C) :
    SET failed on device wlan0 ; Operation not supported.

Although the script has special cases for certain Intel drivers and you
could add eg new line 41 before the default case

    b43) return1;;

I wouldn't recommend doing so both to avoid complexity (don't want it to
end up like pmutils video quirks) and more importantly in case a future
version of the driver fixes the lack of power-saving support.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to pm-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1544612

Title:
  Missing fix for 1299975 claimed to be in pm-utils (1.4.1-13ubuntu0.1)

Status in pm-utils package in Ubuntu:
  Fix Released
Status in pm-utils source package in Trusty:
  In Progress
Status in pm-utils package in Debian:
  Fix Released

Bug description:
  The patch debian/patches/17-fix-wireless-hook.patch for bug 1299975 is
  supposed to be applied in pm-utils (1.4.1-13ubuntu0.1) but is not
  installed in that version from trusty-updates.

  The file /usr/lib/pm-utils/power.d/wireless dated 2014-07-15 16:15 (attached) supposedly installed by the updated package still contains line 23
     [ "$(cat /sys/class/net/$1/device/enabled)" = "1" ] || return 1
  which should be 
     [ "$(cat /sys/class/net/$1/device/enable)" = "1" ] || return 1

  ProblemType: Bug
  DistroRelease: Ubuntu 14.04
  Package: pm-utils 1.4.1-13ubuntu0.1 [modified: usr/lib/pm-utils/pm-functions]
  ProcVersionSignature: Ubuntu 3.13.0-78.122-generic 3.13.11-ckt33
  Uname: Linux 3.13.0-78-generic i686
  ApportVersion: 2.14.1-0ubuntu3.19
  Architecture: i386
  CurrentDesktop: LXDE
  Date: Thu Feb 11 15:10:05 2016
  InstallationDate: Installed on 2014-07-15 (576 days ago)
  InstallationMedia: Lubuntu 14.04 LTS "Trusty Tahr" - Release i386 (20140416.2)
  PackageArchitecture: all
  SourcePackage: pm-utils
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/pm-utils/+bug/1544612/+subscriptions