← Back to team overview

desktop-packages team mailing list archive

[Bug 845549] Re: Do not ship /etc/lightdm/lightdm-gtk-greeter.conf

 

Sorry for the delay, here's a (probably) working patch.

I tested it locally on a clean Xubuntu vm, and it seems to work fine.

I'm not sure how it's going to work with mythbuntu-lightdm-theme,
because this package already diverts the greeter conffile. I wanted to
test that, but I don't have enough time right now (and I've been already
pinged by Robert this morning to post the patch), so it'll stay like
this (and the mtyhbuntu developers will have to handle the possible
breakage themselves: after all, they choose to implement an ugly and
temporary solution instead of pushing for a clean one...).

** Patch added: "Proposed patch"
   https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/845549/+attachment/2439848/+files/debdiff_bug845549.patch

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to lightdm in Ubuntu.
https://bugs.launchpad.net/bugs/845549

Title:
  Do not ship /etc/lightdm/lightdm-gtk-greeter.conf

Status in “lightdm” package in Ubuntu:
  Triaged
Status in “lightdm” source package in Oneiric:
  Triaged

Bug description:
  Hi,

  Currently, the lightdm-gtk-greeter binary package ships /etc/lightdm
  /lightdm-gtk-greeter.conf as a conffile. This is nice for users,
  because they'll get the usual dpkg prompt on upgrades. Unfortunately,
  it's not that great for derivatives where this greeter is used and a
  custom theming is needed.

  I tested quickly, and the gtk greeter is still able to start, and work
  without this config file. So could you please stop shipping it (*and
  handle gracefully its removal in maintainer scripts* -- sorry for the
  highlight, but you didn't do that for /etc/lightdm/lightdm.conf for
  0.4.x -> 0.9.x upgrades...).

  This would allow derivatives to ship their own config file to theme
  the greeter (currently, I can't theme it for Xubuntu without either
  doing some not-so-great things with dpkg-divert, or worse, sed, or
  forking the greeter just to change its settings...).

  Thanks.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lightdm/+bug/845549/+subscriptions


References