← Back to team overview

desktop-packages team mailing list archive

[Bug 813012] Re: Object::dictLookup() not C++ conforming in libpoppler-dev

 

Setting this to invalid as upstream will not fix is.

** Changed in: poppler (Ubuntu)
       Status: New => Invalid

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to poppler in Ubuntu.
https://bugs.launchpad.net/bugs/813012

Title:
  Object::dictLookup() not C++ conforming in libpoppler-dev

Status in Poppler:
  Won't Fix
Status in “poppler” package in Ubuntu:
  Invalid

Bug description:
  In libpoppler-dev there is a minor problem. The function declaration
  of Object::dictLookup and Object::dictLookupNF ist

  In libpoppler-dev:
  Package: libpoppler-dev
  Architecture: amd64
  Source: poppler
  in Ubuntu release: Description:	Ubuntu 11.04, Release:	11.04
  is a minor coding style bug. The function declaration("Object.h", line 216):

    Object *dictLookup(char *key, Object *obj, std::set<int> *fetchOriginatorNums = NULL);
    Object *dictLookupNF(char *key, Object *obj);

  is not conforming to C++ standards. The first argument key is
  constant, so if providing a constant string via "somestring" one gets
  a compile time warning. The same is true for ("Dict.h", line 75):

    Object *lookup(char *key, Object *obj, std::set<int> *fetchOriginatorNums = NULL);
    Object *lookupNF(char *key, Object *obj);

  Later on in the code it is correctly a "const char *". Please fix to
  get rid of this annoying warning.

To manage notifications about this bug go to:
https://bugs.launchpad.net/poppler/+bug/813012/+subscriptions