desktop-packages team mailing list archive

[Dmitry Shachnev <Mitya57@xxxxxxxxx>]

** Description changed:

  I'm currently working on fixing bug 814799 and bug 826771, and I noticed
- that this patch adds duplicate lines:
+ that the mentioned patch adds duplicate lines:
  
  05_desktop_menu_export.patch, lines 120-121:
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->statusbar);
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->menubar);
  
+ lines 129-132:
+ +	/* Don't allow close action on desktop */
+ +	action = gtk_action_group_get_action (NAUTILUS_WINDOW (window)->details->main_action_group,
+ +					      NAUTILUS_ACTION_CLOSE);
+ +	gtk_action_set_sensitive (action, FALSE);
+ 
  These lines already exist in original nautilus_desktop_window.c (they
- are lines 97-98).
- 
- I hope to fix this in my branch together with 2 bugs I mentioned above,
- and I put it here just for better tracking.
+ are lines 71-72 and 74-77).

** Changed in: nautilus (Ubuntu)
     Assignee: Dmitry Shachnev (mitya57) => (unassigned)

** Changed in: nautilus (Ubuntu)
       Status: In Progress => Confirmed

** Tags added: patch-needswork

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/874847

Title:
  05_desktop_menu_export.patch adds duplicate lines

Status in “nautilus” package in Ubuntu:
  Confirmed

Bug description:
  I'm currently working on fixing bug 814799 and bug 826771, and I
  noticed that the mentioned patch adds duplicate lines:

  05_desktop_menu_export.patch, lines 120-121:
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->statusbar);
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->menubar);

  lines 129-132:
  +	/* Don't allow close action on desktop */
  +	action = gtk_action_group_get_action (NAUTILUS_WINDOW (window)->details->main_action_group,
  +					      NAUTILUS_ACTION_CLOSE);
  +	gtk_action_set_sensitive (action, FALSE);

  These lines already exist in original nautilus_desktop_window.c (they
  are lines 71-72 and 74-77).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/874847/+subscriptions