desktop-packages team mailing list archive

[Matthew Gregan <kinetik@xxxxxxxx>]

Comment on attachment 570562
Bug 635918 Part 1 - Make nsISound::Play use libcanberra on Linux rather than esound (v2)

Review of attachment 570562:
-----------------------------------------------------------------

Thanks, looks good.  I do think an nsAutoPtr should be used for the
callback data, comments below.

::: widget/src/gtk2/nsSound.cpp
@@ +152,5 @@
> +    if (!data) {
> +        return;
> +    }
> +    PR_Close(data->mFD);
> +    PR_Delete(data->mPath.get());

These two lines can also be removed, since the destructor will take care
of this when delete is called.

@@ +269,2 @@
>      }
>  

Allocate the CanberraPlayCBData here, like so:
  nsAutoPtr<CanberraPlayCBData> cbdata(new CanberraPlayCBData(fd, path));

@@ +273,5 @@
> +    while (length > 0) {
> +        PRInt32 amount = PR_Write(fd, data, length);
> +        if (amount < 0) {
> +            PR_Close(fd);
> +            PR_Delete(path.get());

Move the close and delete into a destructor for CanberraPlayCBData, then
remove the code from here and the  two error paths below.

@@ +300,3 @@
>  
> +    ca_proplist_sets(p, "media.filename", path.get());
> +    ca_context_play_full(ctx, 0, p, ca_finish_cb, cbdata);

Pass cbdata here using |cbdata.forget()|.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/732572

Title:
  New Mail Notification Sound does not play in Natty

Status in Mozilla Thunderbird Mail and News:
  In Progress
Status in “thunderbird” package in Ubuntu:
  Triaged
Status in “thunderbird” source package in Oneiric:
  Triaged

Bug description:
  Binary package hint: thunderbird

  After setting the preference to play a .wav file and selecting a working .wav file, it will not play by ether:
  1. Clicking the Play button in the preference dialog
  2. Receiving a new email

  Expected result is that it should play the selected file.

  ProblemType: Bug
  DistroRelease: Ubuntu 11.04
  Package: thunderbird 3.1.9+nobinonly-0ubuntu1
  ProcVersionSignature: Ubuntu 2.6.38-5.32-generic-pae 2.6.38-rc6
  Uname: Linux 2.6.38-5-generic-pae i686
  Architecture: i386
  Date: Thu Mar 10 13:23:55 2011
  EcryptfsInUse: Yes
  InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110302)
  ProcEnviron:
   LANGUAGE=en_US:en
   PATH=(custom, user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  SourcePackage: thunderbird
  UpgradeStatus: No upgrade log present (probably fresh install)

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/732572/+subscriptions