desktop-packages team mailing list archive

[Pedro Villavicencio <pedro@xxxxxxxxxx>]

I've followed the test case and the package in proposed is not exhibit
the warning anymore, can't tell though if the gestures are working
(don't have a capable hw) but at least from the normal evince behavior
it seems to work fine. Marking it as verification-done. Thanks all.

** Tags removed: verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to evince in Ubuntu.
https://bugs.launchpad.net/bugs/873866

Title:
  --disable-gestures does not work

Status in “evince” package in Ubuntu:
  Fix Released
Status in “evince” source package in Oneiric:
  Fix Committed

Bug description:
  SRU Justification:
  ==================
  [Impact]
  Gesture support in applications currently requires a tradeoff when dealing with two touch scrolling on trackpads. There may be users who would prefer to operate evince without gesture support. Currently, --disable-gestures/-g does not work.

  [Development Fix]
  The bug has been fixed in the development branch by modifying the libgrip gestures distro patch. Version 3.2.1-0ubuntu2 released in precise has the fix.

  [Stable Fix]
  See http://bazaar.launchpad.net/~ubuntu-desktop/evince/ubuntu/revision/133.

  [Test Case]
  Run evince at the console. The warning about the "enable-gestures" property will show. Run with --disable-gestures and the warning will still appear, and gestures will still be enabled. The list of evince gestures are: two touch pinch to zoom and rotate on touchpads and touchscreens, and two touch drag to scroll on touchscreens. Note this only works with multitouch gesture capable hardware, such as Macbook trackpads and Magic Trackpads

  [Regression Potential]
  Minimal. The patch is extremely straightforward. The enable-gestures property is now checked before registering for gestures, and the unnecessary G_PARAM_CONSTRUCTION_ONLY flag on the property has been removed.

  Original bug report:
  ====================
  The --disable-gestures flag does not work due to two issues:

  1. The enable-gestures gobject class property of the EvView object is created with the G_PARAM_CONSTRUCT_ONLY flag.
  2. The property value is not checked before registering for gestures.

  The first issue causes the following warning in the console:

  (evince:23456): GLib-GObject-WARNING **: g_object_set_valist:
  construct property "enable-gestures" for object `EvView' can't be set
  after construction

  ProblemType: Bug
  DistroRelease: Ubuntu 11.10
  Package: evince 3.2.0-0ubuntu1
  ProcVersionSignature: Ubuntu 3.0.0-12.20-generic 3.0.4
  Uname: Linux 3.0.0-12-generic x86_64
  ApportVersion: 1.23-0ubuntu3
  Architecture: amd64
  Date: Fri Oct 14 02:10:49 2011
  ExecutablePath: /usr/bin/evince
  InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
  ProcEnviron:
   SHELL=/bin/bash
   PATH=(custom, no user)
   LANG=en_CA.UTF-8
   LANGUAGE=en_CA:en
  SourcePackage: evince
  UpgradeStatus: Upgraded to oneiric on 2011-10-13 (0 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/evince/+bug/873866/+subscriptions