← Back to team overview

desktop-packages team mailing list archive

[Bug 874847] Re: 05_desktop_menu_export.patch adds duplicate lines

 

This bug was fixed in the package nautilus - 1:3.2.1-0ubuntu2

---------------
nautilus (1:3.2.1-0ubuntu2) oneiric-proposed; urgency=low

  [ Dmitry Shachnev ]
  * debian/patches/05_desktop_menu_export.patch (updated):
    - Destroy menubar on non-ubuntu sessions (LP: #826771)
    - Remove duplicate lines (LP: #874847)
  * debian/patches/17_dont_allow_new_tab_on_desktop.patch:
    - Don't allow "New tab" shortcut on desktop (LP: #814799)

  [ Martin Pitt ]
  * 05_desktop_menu_export.patch: Fix potential crash if $DESKTOP_SESSION is
    not set.
 -- Dmitry Shachnev <mitya57@xxxxxxxxx>   Tue, 25 Oct 2011 12:46:53 +0200

** Changed in: nautilus (Ubuntu Oneiric)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/874847

Title:
  05_desktop_menu_export.patch adds duplicate lines

Status in “nautilus” package in Ubuntu:
  Fix Released
Status in “nautilus” source package in Oneiric:
  Fix Released
Status in “nautilus” source package in Precise:
  Fix Released

Bug description:
  I'm currently working on fixing bug 814799 and bug 826771, and I
  noticed that the mentioned patch adds duplicate lines:

  05_desktop_menu_export.patch, lines 120-121:
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->statusbar);
  +	gtk_widget_hide (NAUTILUS_WINDOW (window)->details->menubar);

  lines 129-132:
  +	/* Don't allow close action on desktop */
  +	action = gtk_action_group_get_action (NAUTILUS_WINDOW (window)->details->main_action_group,
  +					      NAUTILUS_ACTION_CLOSE);
  +	gtk_action_set_sensitive (action, FALSE);

  These lines already exist in original nautilus_desktop_window.c (they
  are lines 71-72 and 74-77).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/874847/+subscriptions


References