desktop-packages team mailing list archive

[Iagosrl <691380@xxxxxxxxxxxxxxxxxx>]

Hi Blake and Charles,

 Sorry for the delay and thank you for debate.
 Let me explain some tips.

 Unified Search extension borns like a proof concept for the Bug 526221, because some things was dicussed about what is better and what worse, but without possibilities to test it (sometimes, something can seem bad when speeking about but good or no-so-bad when testing it). The extension exists only like attachments in that bug and not published at AMO, was not intended like a production extension. But works well enought, no progress was in resolution of that bug and I decide released.
 Later, a quick solution for Bug 520040 (it's no smart, but works and is only one line solution), and from 0.5 version an implementation for this Bug extremely based on the attached Thomas's mockups. And the idea was the same: to be a proof concept, an extension to test different features, behaviors, to select what is best, what is bad, what can be improved. Not was intented to be exactly the final solution, I'm sorry if this was what seems.

 On other hand, let me say, Blake, all you pointed like possible bugs,
really are, but seems happens only to you (works good for me, and seems
works for Charles), I must continue testing it to discovered and solve
it. But the topic is not this, the extension is not builded to be 'as
is' included in the Thunderbird code, because technical reasons; can be
useful for daily use by power users and useful to speek about what
features and how must be included in Thunderbird, like we are doing now,
and this last is really its goal.

 For example, Unified Search include three alternatives to unified global and filter boxes:
 - Give to the Thunderbird Global Search box filter capabilities (active it from the extension options).
 - Give to the Thunderbird Quick Filter box global search capability (active it from the extension options and disable 'hide quick filter bar' and 'hide quick filter box'; then, press Ctrl+Enter when using the standard filter box to open a global search -press only the Enter key is an available option, but disabled by default because was discussed previously and don't like to several users that use Enter to speed up the filtering, that have a timeout-). By default (without the extension), a global search can be opened from the filter box only when there are no results, with extension you can do it ever.
 - Create a new widget, with both capabilities: current Unified Search Widget do this, but includes several options for testing only:
   - Horizontal bar, vertical bar, and a button to show/hide it (and also a shortcut, press Down key when in widget box): final widget implementation must only include one of them, vertical Or horizontal, and maybe the button can be removed or changed in some way; will be simplier than now, but both options was included because was discussed previously with the Thomas's mockup, extension can be used to test both options and choice the bests (or evolve one of them); "test it to decide", and not only "think about it to decide", was my contribution to help in the process of choosing a solution.
   - Widget working 'all in one', or with two differents modes (one for only search, one for filtering), and the button and shortcut to switch mode: the 'two differents modes' behavior needs a button and shortcut to switch mode, maybe being a more cluttered widget, but 'all in one' without modes without search/filter button needs some way to change between show global search suggestions or not show it (because show global search suggestions can overlap some filtering results if both are working at same time -this behavior can be tested using the standard global search with filtering capabilities enabled and disabling the option 'autocomplete and quick filtering must be incompatible'-). 'All in one' must be thought like current 'filter mode' without the search/filter switch button (imagine it;).

 Another questions:
 - Technically, I'm using the 'Thunderbird global search widget' (gloda box) like the widget base, because of this, all their features are inherit, and then, I change something to implement filtering by synchronizing widget values with the standard quick filter box, because of this Unified Search Extension needs the Quick Filter Bar to exists to work, this must be changed in a Thunderbird implementation of Unified Widget.
 - 'auto-expands/contracts': previously means that auto-expand/contracts features is not implemented by me, is implemented by standard global search widget, and I don't touch it, you can enjoy this feature in the standard search without the extension! I don't know if is a bad or good feature, but is a Thunderbird feature. If don't like you, maybe a bug for this can be opened.
 - 'So when I just tried it, I typed a string, then switched from filter to gloda, and the string disappeared': it's a bug, the behavior must be that the string is presserved in order to allow you to see the search suggestions (that appear automatically when switch), it's the idea; But works fine to me, I couldn't repeat the bug :(.
 - 'For the add-on's popup, there's no indication of what the various icons are, or which keys I would use to activate them.': I use the standard Mozilla-XUL method to implement key-shortcuts, meaning that a letter is underscored or between brackets in the button text; but I see in your screenshots that you are using 'icons only' in the preferences of your toolbar, this hide all texts in Thunderbird buttons and Unified Search buttons too. Just like the standard. Maybe an alternative to the standard can be used (any idea?) or have a 'customize' preference different for the widget options bar (pop-up with the filtering options). New users will see the texts and shortcuts reminders because 'icons beside text' is the default configuration in Thunderbird. Note: if you have opened the Thunderbird Quick Filter Bar when trying to use the shortcuts from Unified Search Widget, shortcuts will no work because a conflict, but is a bug that only happens with both opened, the idea is have only one bar, not both.
 - I know some filtering options shortcuts overrules some menu shortcuts, is a knowed bug. Note that Thunderbird quick filter bar have not shortcuts for this options/buttons by default, are included with the extension.
 - 'For the add-on, to clear the options, Esc+Esc is a _horrible_ key combination.  (I also have no idea what "Clear Options" actually does…)': It's only doing the same that Thunderbird Quick Filter Box does (that really is a three-Esc process); maybe a proposal can be opened like a new bug, and I can try to implement it in the extension to test it. To explain, Thunderbird developers decision was:
    - One Esc: clear filtering text; if no text, clear last filter option (un-press/un-select button); if no text and no options selected, close quick filter bar.
    - Second Esc: clear options (un-press/un-selects buttons)
    - Third Esc: close quick filter bar.
    - Press clear button: clear filtering text; here there is a small difference in Unified Search Widget: clear button clear the text and the options (is like reset all filtering options). What behavior is preferred here, clear all or clear only text?
 - 'I agree there is more stuff displayed at the start in the QFB, but it's better organized, and so easier to understand, and I don't think the add-on actually does any less so it's not actually more minimal.': Yes, the idea is just do the same in less space and organization I think is quite similar, only changed the main place where widget is and some options in a popup/menu (despite the behavior of use 'icons only' for options, it's a config matter, not what a new user will see with default profile -'icons beside text' is the default config-). But it's important for small screens, like netbooks, be minimal: I have users that 'love' Unified Search Widget just for this and hate standard big bar.
 - 'Why is there an icon to show or hide the extra popup?': because is needed for the horizontal menu; if the prefered option is have the popup bar and remove the horizontal menu, we can remove the button.
 - 'Once I type something, and the bar is popped up, how do I navigate to it with the keyboard?': it's a weak, shared with the standard Thunderbird quick filter bar (spite of this, the bar was included in thunderbird); only can be 'navigated' with shortcuts. Any technique solution is welcome (we can open a new bug for this, because happens to Thunderbird just now from 3.1 version).
 - 'I think we can have something that offers both filtering and global search without making people specify which one they want, by extending the behaviour of the QFB when you type in something like "fjdsfjslfnsdkfn" to also cover cases where there are matches, and that seems like a better way to go to me…': I explain this previously, try the filter-box with global search capabilities, global search with filtering capabilities, or using the unified search widget only in filtering mode and press Ctrl+Enter to do a global search and say us what you prefer, or what approach is closest to what you prefer and we can work on the right track.
 - A bug in Unified Search Widget: no message is included saying the number of messages found; if preference 'hide quick filter bar' is selected, no coloured border appear, only a different background colour.
 - A bug in Unified Search Widget: no options to select what tags you want to filter on, Quick Filter Bar let you choose some tags after press 'Tags' button.

 'Nothing' more ;-)
 Sorry for the large text, I hope I was clear, please ask any questions.

Thanks,
IagoSRL

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/691380

Title:
  Quick Search  Filter should be moveable

Status in Mozilla Thunderbird Mail and News:
  Confirmed
Status in “thunderbird” package in Ubuntu:
  Triaged
Status in “thunderbird” source package in Lucid:
  Triaged

Bug description:
  Binary package hint: thunderbird

  Today I updated lucid 3.0.4 TB to 3.1.7 from security.  I never liked
  the new "smart" search feature but relied mostly on filtering on To,
  CC and recipient.  I had put the search field for that on the menu bar
  so no further screen real estate was used on my netbook.  3.1.7 now
  introduces a UI regression in that that search field is used solely
  for the dumb "smart" search that opens a tab to waste even more screen
  space.  To use the search that I care about I have to use the quick
  search bar, more lost screen space.  And when I actually use it it
  opens another bar to filter and by then I can't even see my messages
  any longer.

  Seriously, netbooks are here to stay.  What were the UI devs thinking
  looking at their 28" TFT display all day?

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/691380/+subscriptions