desktop-packages team mailing list archive

[Martin Pitt <martin.pitt@xxxxxxxxxx>]

+        m = re.match(".*(file:/|://)(.*)", u)

I don't understand why this is necessary. file apt sources should still
be complete URLs, i. e. file://relative_path or file:///absolute/path.
file:/path/name/ is not a real URL, and I don't want to support this.
And of course I don't want to allow unsigned binary archives in the
official ubuntu package.

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to jockey in Ubuntu.
https://bugs.launchpad.net/bugs/913927

Title:
  Jockey will fail against local disk archive

Status in OEM Priority Project:
  Incomplete
Status in “jockey” package in Ubuntu:
  Incomplete

Bug description:
  Ubuntu 11.10
  Jockey 0.9.4-0ubuntu10

  Some logic looks problematic and is causing jockey to fail to find
  drivers on our on-disk repositories.  Local on-disk archives are used
  a lot in OEM on customer's first boot.  We are currently carrying
  patches to Jockey for a number of OEM projects to get around this.

  I have found 3 issues in the code related to this:

  1.  The code in OSLib::has_repositories assumes URIs - "://" from apt-
  cache policy.  If the archive is file based it will be
  "file:/foo/bar/..." and so will not satisfy the test.

  2.  There is also a similar problem in the detection.py code -
  DriverDB::_cache_id(self), which also assumes a "://".  When I altered
  it to this (along with fixing the above) jockey worked as I would
  hope:

      m = re.match(".*::/{1,2}(.*)")
      if m:
           u = m.group(1)

  But I'm not sure if that's sufficiently tight?  Perhaps
  ".*(file:/|://)(.*)", and then group(2)?

  3.  The on-disk binary drivers will be unsigned, so will fail.  I
  would think an appropriate solution would be to allow the signature
  checking to be turned off with a command line option.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oem-priority/+bug/913927/+subscriptions