desktop-packages team mailing list archive

[Mkmelin+mozilla <1360086@xxxxxxxxxxxxxxxxxx>]

Comment on attachment 8463013
bug1043784_tab_adds_address_row.patch

[Approval Request Comment]
Regression caused by (bug #): bug 959209
User impact if declined: tab in autocomplete adds a new line, instead of just going to end of completion
Testing completed (on c-c, etc.): landed on trunk
Risk to taking this patch (and alternatives if risky): not risky

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1360086

Title:
  Thunderbird 31 regression: changing focus with <TAB> in compose window
  during address autocompletion

Status in Mozilla Thunderbird Mail and News:
  Fix Released
Status in “thunderbird” package in Ubuntu:
  Confirmed

Bug description:
  There are two similar/related regressions in Thunderbird 31, when
  typing address(es) in the 'To' field(s) of the compose window. Both
  regressions involve the widget focus behavior when navigating via
  keyboard after typing an address that is in your autocompletion
  address list. In one case, we see unexpected behavior when pressing
  <TAB> while autocompleting an address, and in the second case, we see
  unexpected behavior when pressing <SHIFT>+<TAB> in the same scenario.

  Comments are borrowed below from the upstream bug reports:

  https://bugzilla.mozilla.org/show_bug.cgi?id=1043784
  https://bugzilla.mozilla.org/show_bug.cgi?id=1051564

  Issue #1:

  STR
  1 compose new msg
  2 in exactly the last empty recipient row (with set recipient type), type a searchword which triggers at least one autocomplete suggestion: e.g. [To: ][searchword >> autocomplete suggestion]
  3 press <tab>

  Actual Result (TB31)

  a) focus moves away from the current recipient row immediately
  b) a new empty recipient row is created
  c) the just-added recipient row gets focus

  Expected Result (as in TB24)

  b) don't create a new empty recipient row
  c) As a consequence, as there's no other (empty or filled) row widget after the just-filled row widget, move focus to the next widget, which happens to be Subject box.


  Issue #2:

  
  STR
  1 compose new msg
  2 in exactly the last empty recipient row (with set recipient type), type a searchword which triggers at least one autocomplete suggestion: e.g. [To: ][searchword >> autocomplete suggestion]
  3 press <shift>+<tab>

  Actual Result (TB31)

  a) focus moves away from the current recipient row immediately
  b) a new empty recipient row is created
  c) the just-added recipient row gets focus

  Expected Result (as in TB24)

  b) no new recipient row is created
  c) jump to the 'To:' combo box (i.e., the previous widget, rather than the next widget)

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/1360086/+subscriptions