desktop-packages team mailing list archive

["Stephen M. Webb" <stephen.webb@xxxxxxxxxxxxx>]

** Changed in: compiz
       Status: Fix Committed => Fix Released

** Changed in: compiz/0.9.9
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101571

Title:
  Coverity SECURE_CODING - CID 12512

Status in Compiz:
  Fix Released
Status in Compiz 0.9.9 series:
  Fix Released
Status in “compiz” package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12512
  Checker: SECURE_CODING
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/676.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/dbus/src/dbus.cpp
  Function: DbusScreen::sendChangeSignalForOption(CompOption *, const std::basic_string<char, std::char_traits<char>, std::allocator<char>>&)
  Code snippet:
  1649 
  1650     if (!o)
  1651 	return;
  1652 
  CID 12512 - SECURE_CODING
  [VERY RISKY]. Using "sprintf" can cause a buffer overflow when done incorrectly.  Because sprintf() assumes an arbitrarily long string, callers must be careful not to overflow the actual space of the destination. Use snprintf() instead, or correct precision specifiers.
  1653     sprintf (path, "%s/%s/%s/%s", COMPIZ_DBUS_ROOT_PATH,
  1654 	     plugin.c_str (), "options", o->name ().c_str ());
  1655 
  1656     signal = dbus_message_new_signal (path,
  1657 				      COMPIZ_DBUS_SERVICE_NAME,
  1658 				      COMPIZ_DBUS_CHANGED_SIGNAL_NAME);

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101571/+subscriptions