desktop-packages team mailing list archive

["Stephen M. Webb" <stephen.webb@xxxxxxxxxxxxx>]

** Changed in: compiz
       Status: Fix Committed => Fix Released

** Changed in: compiz/0.9.9
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101565

Title:
  Coverity SECURE_CODING - CID 12519

Status in Compiz:
  Fix Released
Status in Compiz 0.9.9 series:
  Fix Released
Status in “compiz” package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12519
  Checker: SECURE_CODING
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/676.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/plugins/water/src/water.cpp
  Function: WaterScreen::waterSetup()
  Code snippet:
  263 	program[SET] = new GLProgram (set_water_vertices_vertex_shader,
  264 	                              set_water_vertices_fragment_shader);
  265 
  266 	if (target == GL_TEXTURE_2D)
  CID 12519 - SECURE_CODING
  [VERY RISKY]. Using "sprintf" can cause a buffer overflow when done incorrectly.  Because sprintf() assumes an arbitrarily long string, callers must be careful not to overflow the actual space of the destination. Use snprintf() instead, or correct precision specifiers.
  267 	    sprintf (buf, update_water_vertices_fragment_shader.c_str (),
  268 		     "2D", "2D",
  269 		     1.0f / (float) texWidth,  1.0f / (float) texWidth,
  270 		     1.0f / (float) texHeight, 1.0f / (float) texHeight,
  271 		     "2D", "2D", "2D", "2D");
  272 	else

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101565/+subscriptions