desktop-packages team mailing list archive

["Stephen M. Webb" <stephen.webb@xxxxxxxxxxxxx>]

** Changed in: compiz
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1114525

Title:
  cppcheck static code analysis reveals some true positives

Status in Compiz:
  Fix Released
Status in “compiz” package in Ubuntu:
  Fix Released

Bug description:
  [plugins/trailfocus/src/trailfocus.cpp:227]: (style) Unused variable:
  iter

  [plugins/thumbnail/src/thumbnail.cpp:284]: (style) Variable 'distance'
  is assigned a value that is never used.

  [plugins/td/src/3d.cpp:491] -> [plugins/td/src/3d.cpp:495]:
  (performance) Variable 'rv' is reassigned a value before the old one
  has been used.

  [src/screen.cpp:2700]: (performance) Prefix ++/-- operators should be
  preferred for non-primitive types. Pre-increment/decrement can be more
  efficient than post-increment/decrement. Post-increment/decrement
  usually involves keeping a copy of the previous value around and adds
  a little extra code.

  [src/window.cpp:3449]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
  [src/window.cpp:3459]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.
  [src/window.cpp:4062]: (performance) Prefix ++/-- operators should be preferred for non-primitive types. Pre-increment/decrement can be more efficient than post-increment/decrement. Post-increment/decrement usually involves keeping a copy of the previous value around and adds a little extra code.

  [plugins/decor/src/decor.cpp:890]: (error) Uninitialized variable: frameType
  [plugins/decor/src/decor.cpp:891]: (error) Uninitialized variable: frameState
  [plugins/decor/src/decor.cpp:892]: (error) Uninitialized variable: frameActions

  [plugins/group/src/glow.cpp:323] -> [plugins/group/src/glow.cpp:346]:
  (performance) Variable 'x2' is reassigned a value before the old one
  has been used.

  [plugins/resize/src/logic/src/resize-logic.cpp:1372] -> [plugins/resize/src/logic/src/resize-logic.cpp:1379]: (performance) Variable 'lco' is reassigned a value before the old one has been used.
  [plugins/resize/src/logic/src/resize-logic.cpp:1372] -> [plugins/resize/src/logic/src/resize-logic.cpp:1380]: (performance) Variable 'rco' is reassigned a value before the old one has been used.
  [plugins/resize/src/logic/src/resize-logic.cpp:1372] -> [plugins/resize/src/logic/src/resize-logic.cpp:1381]: (performance) Variable 'tco' is reassigned a value before the old one has been used.
  [plugins/resize/src/logic/src/resize-logic.cpp:1372] -> [plugins/resize/src/logic/src/resize-logic.cpp:1382]: (performance) Variable 'bco' is reassigned a value before the old one has been used.

  [plugins/resizeinfo/src/resizeinfo.cpp:138]: (warning) %d in format string (no. 1) requires a signed integer given in the argument list.
  [plugins/resizeinfo/src/resizeinfo.cpp:138]: (warning) %d in format string (no. 2) requires a signed integer given in the argument list.

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1114525/+subscriptions