← Back to team overview

desktop-packages team mailing list archive

[Bug 1388875] Re: [gtk-mir-backend] Clicking seems to confuse GTK (or the shell)

 

I think the fix is:

--- a/gdk/mir/gdkmireventsource.c
+++ b/gdk/mir/gdkmireventsource.c
@@ -311,7 +313,7 @@ handle_motion_event (GdkWindow *window, const MirMotionEvent *event)
     case mir_motion_action_up:
       event_type = event->action == mir_motion_action_down ? GDK_BUTTON_PRESS : GDK_BUTTON_RELEASE;
       changed_button_state = button_state ^ event->button_state;
-      if ((changed_button_state & mir_motion_button_primary) != 0)
+      if (changed_button_state == 0 || (changed_button_state & mir_motion_button_primary) != 0)
         generate_button_event (window, event_type, x, y, GDK_BUTTON_PRIMARY, modifier_state);
       if ((changed_button_state & mir_motion_button_secondary) != 0)
         generate_button_event (window, event_type, x, y, GDK_BUTTON_SECONDARY, modifier_state);

I'm EOD - will pick this up tomorrow unless someone else wants to look
at it.

** Also affects: gtk+3.0 (Ubuntu Utopic)
   Importance: Undecided
       Status: New

** Also affects: gtk+3.0 (Ubuntu Vivid)
   Importance: High
     Assignee: Robert Ancell (robert-ancell)
       Status: Triaged

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gtk+3.0 in Ubuntu.
https://bugs.launchpad.net/bugs/1388875

Title:
  [gtk-mir-backend] Clicking seems to confuse GTK (or the shell)

Status in “gtk+3.0” package in Ubuntu:
  Triaged
Status in “gtk+3.0” source package in Utopic:
  New
Status in “gtk+3.0” source package in Vivid:
  Triaged

Bug description:
  Using utopic or current vivid, clicking on buttons/menubar in gtk
  application under unity8-mir leads to not working softwares.

  Not sure if that's the GTK backend or Mir to blame

  Small example attached, the program has a button and a label, click on the button should display "clicked!".
  Under unity8 the button seems to stop reacting after the first click and sometime the program closes

  (compile with "gcc button.c -o button`pkgconfig --cflags --libs
  gtk+-3.0`", to run it you need to have a .desktop running the binary
  and including the X-Ubuntu-Touch=true key)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1388875/+subscriptions


References