desktop-packages team mailing list archive

[Kees Cook <kees@xxxxxxxxxx>]

** Also affects: libreoffice (Ubuntu Vivid)
   Importance: High
     Assignee: Björn Michaelsen (bjoern-michaelsen)
       Status: Confirmed

** Changed in: libreoffice (Ubuntu Trusty)
       Status: New => Confirmed

** Changed in: libreoffice (Ubuntu Trusty)
   Importance: Undecided => High

** Changed in: libreoffice (Ubuntu Trusty)
     Assignee: (unassigned) => Björn Michaelsen (bjoern-michaelsen)

** Tags added: regression-release

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to libreoffice in Ubuntu.
https://bugs.launchpad.net/bugs/1319941

Title:
  libreoffice draw / impress crash if user service publishing is
  disabled in avahi

Status in LibreOffice Productivity Suite:
  Fix Released
Status in “libreoffice” package in Ubuntu:
  Confirmed
Status in “libreoffice” source package in Trusty:
  Confirmed
Status in “libreoffice” source package in Vivid:
  Confirmed
Status in “libreoffice” package in Debian:
  Fix Released

Bug description:
  [Impact]

   * Impress and Draw will not work (Crash) with Avahi enabled, but user/all publishing disabled.
   * The fix is basically some check before free, and return earlier if failing.

  [Test Case]

   * Restart avahi daemon with either disable-user-service-publishing=yes or disable-publishing=yes.  This will cause the crash.
   * Patch was also tested with avahi on, making sure it publishes and with avahi just to make sure a new bug was not introduced.

  [Regression Potential]

   * If a regression occurs it would be avahi specific and should only affect Impress and Draw.  It will be less likely to manifest in an outright crash now.
   * I was unable to test actually using a remote control. (but the avahi service was published which is the only part my fix touches.

  [Other Info]
  Avahi is NOT enabled in Upstream LibreOffice builds (so don't try to test them for this bug) although pushing to have source fix included in 4.2.x and 4.3.x anyways
  Master Upstream fix (TB4.4): http://cgit.freedesktop.org/libreoffice/core/commit/?id=3c57701cf0a169bd8d1893d1b2271d48b8072147
  Proposed 4.3: https://gerrit.libreoffice.org/#/c/10816/
  Proposed 4.2: http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-4-2&id=8de2e9b4bc53e6c097897142bad223c100d36292

  Both loimpress and lodraw fail to start with an error message related
  to avahi:

  $ loimpress
  avahi_entry_group_new() failed: Not permitted
  soffice.bin: client.c:626: avahi_client_free: Assertion `client' failed.

  $ ps ax | grep avahi
   7617 pts/0    S+     0:00 grep --color=auto avahi
  21356 ?        S      0:07 avahi-daemon: running [hostname.local]
  21380 ?        S      0:00 avahi-daemon: chroot helper

  This is the backtrace of the crash:

  $ cat gdbtrace.log
  warning: Currently logging to gdbtrace.log.  Turn the logging off and on to make the new setting effective.
  warning: Unable to find libthread_db matching inferior's thread library, thread debugging will not be available.

  Program received signal SIGABRT, Aborted.
  0x00007ffff41f2f79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
  56	../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
  #0  0x00007ffff41f2f79 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
  #1  0x00007ffff41f6388 in __GI_abort () at abort.c:89
  #2  0x00007ffff41ebe36 in __assert_fail_base (fmt=0x7ffff433d718 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7fffe95b6919 "client", file=file@entry=0x7fffe95b6910 "client.c", line=line@entry=626, function=function@entry=0x7fffe95b6fe0 "avahi_client_free") at assert.c:92
  #3  0x00007ffff41ebee2 in __GI___assert_fail (assertion=0x7fffe95b6919 "client", file=0x7fffe95b6910 "client.c", line=626, function=0x7fffe95b6fe0 "avahi_client_free") at assert.c:101
  #4  0x00007fffe95af06b in avahi_client_free () from /usr/lib/x86_64-linux-gnu/libavahi-client.so.3
  #5  0x00007fffbac7c40c in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #6  0x00007fffbac7c678 in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #7  0x00007fffe95aec2c in ?? () from /usr/lib/x86_64-linux-gnu/libavahi-client.so.3
  #8  0x00007fffe95af3aa in avahi_client_new () from /usr/lib/x86_64-linux-gnu/libavahi-client.so.3
  #9  0x00007fffbac7c8a5 in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #10 0x00007fffbac7d195 in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #11 0x00007fffbac7d30b in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #12 0x00007fffbac74756 in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #13 0x00007fffbaa12b9b in ?? () from /usr/lib/libreoffice/program/../program/libsdlo.so
  #14 0x00007fffbab83bc0 in sd_component_getFactory () from /usr/lib/libreoffice/program/../program/libsdlo.so

  This is on trusty.

  libreoffice-impress 1:4.2.3~rc3-0ubuntu

To manage notifications about this bug go to:
https://bugs.launchpad.net/df-libreoffice/+bug/1319941/+subscriptions