← Back to team overview

desktop-packages team mailing list archive

[Bug 1393902] Re: GOOG search credit flag isn't always in search queries

 

As far as I can tell,  synchronization of profiles with different search
templates stored in the preferences is to blame for the variability.

Some recent version of chromium's in-source pre-populated search list
dropped the "{google:searchClient}" token, and that means local
overriding of that token had no effect.

Now, I test whether the search template is of the google-search variety
-- id est, it has "{google:baseURL}" token. If the template also sets
the client naturally (as for old profile data) then it is used, but if
it doesn't (as for recent profiles) I forcibly append one on the end.
That should solve both cases.

** Changed in: chromium-browser (Ubuntu)
       Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to chromium-browser in Ubuntu.
https://bugs.launchpad.net/bugs/1393902

Title:
  GOOG search credit flag isn't always in search queries

Status in “chromium-browser” package in Ubuntu:
  Fix Committed

Bug description:
  We expect "client=ubuntu" or "client=browser-ubuntu" in every GOOG
  search query URL.

  It isn't in every search, but is in some. The user-profile's age
  (probably in versions, not time) seems to be a factor, or whether one
  is logged-in to Google for sync seems to be a factor too.

  data:

  who:
  (ntpf|loc)  New Tab Page Form or Location
  L=logged in too G Apps
  N=profile created with this version
  (nn) = version
  "client=value"

  cm: ntpf  N (37.0.2062.94=utopicrel) "client=ubuntu-browser"
  cm: loc   N (37.0.2062.94=utopicrel) "client=ubuntu-browser"
  cm: ntpf LN (37.0.2062.94=utopicrel) "client=ubuntu-browser"
  cm: loc  LN (37.0.2062.94=utopicrel) "client=ubuntu-browser"
  cm: ntpf  N (34.0.1847.116=trustyrel) "client=ubuntu-browser"
  cm: loc   N (34.0.1847.116=trustyrel) "client=ubuntu-browser"
  cm: ntpf LN (38.0.2125.111) "client=ubuntu-browser"
  cm: ntpf  N (38.0.2125.111) "client=ubuntu-browser"
  cm: ntpf L  (38.0.2125.111) "client=ubuntu-browser"
  cm: ntpf    (38.0.2125.111) "client=ubuntu-browser"
  cm: loc  LN (38.0.2125.111) "client=ubuntu-browser"
  cm: loc   N (38.0.2125.111) "client=ubuntu-browser"
  cm: loc  L  (38.0.2125.111) "client=ubuntu-browser"
  cm: loc     (38.0.2125.111) "client=ubuntu-browser"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1393902/+subscriptions


References