desktop-packages team mailing list archive

[Bug Watch Updater <1021813@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 38 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=765803.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2012-06-18T17:01:11+00:00 Jbg-w wrote:

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8)
AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.142
Safari/535.19

Steps to reproduce:

Reply to a message with the "reply above" option set


Actual results:

TB used to include at least one blank line before the reply section, now
it jams the reply right up against the first line of the reply area.


Expected results:

Leave at least one blank line, or make the amount of space configurable.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/0

------------------------------------------------------------------------
On 2012-06-18T23:04:06+00:00 Rsx11m-pub wrote:

*** Bug 765826 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/1

------------------------------------------------------------------------
On 2012-06-18T23:10:10+00:00 Rsx11m-pub wrote:

Looks like a regression in the 13.0 HTML editor, possibly introduced
with the new filelink feature. Steps to reproduce:

1. Compose in HTML mode
2. Don't have a signature defined
3. Set "reply above quote"

Clicking reply inserts two blank lines above the reply header in 10.0.5
ESR and places the cursor to the first one. On 14.0a2, there is only a
single blank line above the <div class="moz-cite-prefix"> node.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/2

------------------------------------------------------------------------
On 2012-06-18T23:17:45+00:00 Rsx11m-pub wrote:

Plain-text composition doesn't appear to be affected.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/3

------------------------------------------------------------------------
On 2012-06-26T06:31:28+00:00 hashemmasoud wrote:

*** Bug 768292 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/4

------------------------------------------------------------------------
On 2012-06-26T14:55:34+00:00 Rsx11m-pub wrote:

*** Bug 767752 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/5

------------------------------------------------------------------------
On 2012-07-09T16:29:56+00:00 Nixon049 wrote:

This occurs even if a signature is defined, so long as signature is
placed below the quote.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:13.0) Gecko/20120614
Thunderbird/13.0.1 ID:20120614161456

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/9

------------------------------------------------------------------------
On 2012-07-13T16:41:31+00:00 Jake1138 wrote:

I noticed this recently too.  I am running 13.0.1.  I hope this gets
fixed soon.  It's really annoying.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/14

------------------------------------------------------------------------
On 2012-07-13T17:20:34+00:00 Alice0775 wrote:

Regression window
Good:
http://hg.mozilla.org/comm-central/rev/3ad9c88900d6
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120313 Thunderbird/13.0a1 ID:20120313030025
Bad:
http://hg.mozilla.org/comm-central/rev/1593bfcee4fb
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120314 Thunderbird/14.0a1 ID:20120314030025
Pushlog:
http://hg.mozilla.org/comm-central/pushloghtml?fromchange=3ad9c88900d6&tochange=1593bfcee4fb

Suspected : Bug 735380

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/15

------------------------------------------------------------------------
On 2012-09-05T07:02:53+00:00 Brian Norris wrote:

I can confirm that this bug still exists in 15.0. I'm using Ubuntu
12.04.

This issue has been reported on the Ubuntu launchpad tracker:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/16

------------------------------------------------------------------------
On 2012-09-28T01:10:26+00:00 Thorokol wrote:

I am using 15.0.1 and I've been waiting for many versions for this to be
fixed. I've been using Thunderbird since the very beginning and this is
very annoying as it only got introduced into TB a few versions ago.
Please fix this.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/17

------------------------------------------------------------------------
On 2012-11-29T22:39:48+00:00 Toban57 wrote:

I'm running Thunderbird 17.0, portable on XP, and this is STILL an
issue.  Does not look like they are working on this bug too hard.  Very
annoying!

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/18

------------------------------------------------------------------------
On 2012-11-29T22:44:20+00:00 Toban57 wrote:

I'm running Thunderbird 17.0, portable on XP, and this is STILL an
issue.  Does not look like they are working on this bug too hard.  Very
annoying!

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/19

------------------------------------------------------------------------
On 2012-11-29T22:45:34+00:00 Toban57 wrote:

I'm running Thunderbird 17.0, portable on XP, and this is STILL an
issue.  Does not look like they are working on this bug too hard.  Very
annoying!

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/20

------------------------------------------------------------------------
On 2012-11-29T22:50:39+00:00 Toban57 wrote:

Sorry about the multiple posts.  Not sure how to delete the two
duplicates.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/21

------------------------------------------------------------------------
On 2012-11-30T01:57:48+00:00 Antoine-mechelynck-gmail wrote:

(In reply to Toby Banner from comment #14)
> Sorry about the multiple posts.  Not sure how to delete the two duplicates.

You can't. Just be more careful next time. :-)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/22

------------------------------------------------------------------------
On 2012-12-02T07:51:02+00:00 Brian Norris wrote:

Created attachment 687497
Path: adds back a newline for HTML replies

Since there's been no real help from Mozilla, I'm posting my own fix.
This fixes the worst annoyance -- the missing newline at the start of
HTML, reply-on-top mail -- but it still leaves a seemingly-extraneous
newline below the quote. Please at least give this a look.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/23

------------------------------------------------------------------------
On 2013-03-23T08:07:36+00:00 Brian Norris wrote:

Bump! Mike, can you take a look at this? Or shall I find a different
reviewer?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/24

------------------------------------------------------------------------
On 2013-03-23T14:11:36+00:00 Mike Conley wrote:

Created attachment 728622
Test fix

This test needs to be modified in order to accommodate the new patch.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/25

------------------------------------------------------------------------
On 2013-03-23T14:13:28+00:00 Mike Conley wrote:

Comment on attachment 687497
Path: adds back a newline for HTML replies

Review of attachment 687497:
-----------------------------------------------------------------

This appears to fix the described problem, although it breaks one of the
Filelink tests (which I've added a patch to address). So I like this!

I think we'll need to request review from the SM folks, since this is a
mailnews change.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/26

------------------------------------------------------------------------
On 2013-03-23T14:16:57+00:00 Mike Conley wrote:

Comment on attachment 728622
Test fix

We've added an extra line break, so we have to modify one of the tests
to accommodate it. Blake, you originally reviewed these tests...does
this look OK to you?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/27

------------------------------------------------------------------------
On 2013-03-23T19:40:33+00:00 Johnvorhaus wrote:

Is there any fix available as an ADD-IN or a SETTING CHANGE? I'm lost in
code and am look for something even a STOOPID person can master. Thanks.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/28

------------------------------------------------------------------------
On 2013-03-23T20:21:23+00:00 Brian Norris wrote:

(In reply to johnvorhaus from comment #21)
> Is there any fix available as an ADD-IN or a SETTING CHANGE? I'm lost in
> code and am look for something even a STOOPID person can master. Thanks.

Hi John (forgive me if that is not your name),

This fix is seemingly making progress toward being included in an
upcoming Thunderbird release, and so it will not need an add-on or other
workaround. Please be patient, and hopefully this regression will be
squashed!

If, however, you want an immediate solution, I did find a workaround
that sorta works (it fixes HTML mail but adds an *extra* newline for
plain text mail) here:

https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/5

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/29

------------------------------------------------------------------------
On 2013-03-29T07:47:36+00:00 Brian Norris wrote:

Just a ping: any responses from Neil or Blake on the bugfix + test case?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/30

------------------------------------------------------------------------
On 2013-04-01T17:04:04+00:00 Bwinton-a wrote:

Comment on attachment 728622
Test fix

Yeah, this change seems okay to me, assuming it makes the test pass…

Thanks,
Blake.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/31

------------------------------------------------------------------------
On 2013-04-11T04:57:36+00:00 Brian Norris wrote:

Ping: Neil, can you review the bugfix patch? If not, what's the next
step?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/32

------------------------------------------------------------------------
On 2013-06-19T18:15:25+00:00 Josiah-l wrote:

Neil seems pretty busy.

IanN, do you have a few to review this? (Looks like this is your area)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/35

------------------------------------------------------------------------
On 2013-12-05T11:35:05+00:00 Pf4public wrote:

Any news on this?

Tried user.js with
// Modify quote header //
 user_pref("mailnews.reply_header_ondate", "\nOn %s");

but it does not help
TB version 24.1.1

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/36

------------------------------------------------------------------------
On 2014-03-20T22:45:30+00:00 Louiserbaldwin wrote:

Small patch to fix major annoyance is just waiting review for the past
year. Come on, ladies and gentlemen. How can we find someone to review
this?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/37

------------------------------------------------------------------------
On 2014-03-20T22:52:50+00:00 Josiah-l wrote:

Neil, could you please review this quickly? It's a two liner.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/38

------------------------------------------------------------------------
On 2014-04-13T15:24:05+00:00 Pf4public wrote:

Obviously, it is way too difficult to fix this :(

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/39

------------------------------------------------------------------------
On 2014-06-18T07:00:14+00:00 Brian Norris wrote:

Time for an annual checkup here. Anyone listening? Can the provided
patch be applied?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/40

------------------------------------------------------------------------
On 2014-06-18T13:48:24+00:00 Josiah-l wrote:

If I can't get Neil to look at this later today then I think Mike or
myself could probably just review it.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/41

------------------------------------------------------------------------
On 2014-06-20T06:45:46+00:00 Brian Norris wrote:

(In reply to Josiah Bruner [:JosiahOne] from comment #32)
> If I can't get Neil to look at this later today then I think Mike or myself
> could probably just review it.

It's past "later today" on all parts of the globe ;) Can you or Mike
take a look please?

FWIW, I retested against the latest, and everything patches and runs as
expected.

(Now that I'm revisiting the history, it looks like Mike already added
his "review+", which I think means my patch was officially "reviewed."
But then he pushed it back to Neil, who hasn't responded. Can we just
finish this off already?)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/42

------------------------------------------------------------------------
On 2014-06-20T09:54:33+00:00 Neil-httl wrote:

Comment on attachment 687497
Path: adds back a newline for HTML replies

Sorry for dropping the ball on this.

Editor is a bit strange when it comes to breaks, in particular you need
a break in an empty block so that you can put the caret there, so it
creates a bogus break to achieve this.

However when you insert a break (e.g. by pressing Enter in an empty
Compose window) this bogus break gets deleted, and the net result is
that nothing happens, which is unhelpful.

Inserting a break by pressing Shift+Enter does force the insert of a
break without deleting the bogus break, but there's no direct function
to achieve this, and the one API point we have behaves differently in
plain text compose.

So I think the best solution here is to move this extra break to the
beginning of the if (reply_on_top == 1) block, with a suitable comment
to the effect that the HTML editor eats the initial break.

(On an unrelated note, the code to detect a signature is over-engineered
- any signature is already in aSignature at this point.)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/43

------------------------------------------------------------------------
On 2014-07-05T21:44:27+00:00 Brian Norris wrote:

(In reply to neil@xxxxxxxxxxxxxxx from comment #34)
> So I think the best solution here is to move this extra break to the
> beginning of the if (reply_on_top == 1) block, with a suitable comment to
> the effect that the HTML editor eats the initial break.

So you'd like essentially the same patch, just moved around and with an
extra comments? I'll respin, retest, and flag you for review shortly.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/44

------------------------------------------------------------------------
On 2014-07-05T23:09:13+00:00 Brian Norris wrote:

Created attachment 8451310
Patch: adds back a newline for HTML replies (version 2)

Adding version 2 patch. Essentially the same, refactorerd to address
comments. Please review, Neil.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/45

------------------------------------------------------------------------
On 2014-11-07T13:54:45+00:00 Patrick Cloke wrote:

https://hg.mozilla.org/comm-central/rev/e1e1955cce9c
https://hg.mozilla.org/comm-central/rev/64e49d15dff7

Reply at:
https://bugs.launchpad.net/ubuntu/+source/thunderbird/+bug/1021813/comments/46


** Changed in: thunderbird
       Status: Unknown => Fix Released

** Changed in: thunderbird
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to thunderbird in Ubuntu.
https://bugs.launchpad.net/bugs/1021813

Title:
  Thunderbird places incorrect newlines when composing a reply using
  "reply above quote"

Status in Mozilla Thunderbird Mail and News:
  Fix Released
Status in thunderbird package in Ubuntu:
  Confirmed

Bug description:
  When I compose a reply to any message, the newlines placed around the
  quote are incorrectly formatted. I am using "reply above the quote",
  and I only get a single newline above the quote, but there's two
  newlines below the quote. This means I always have to click around and
  press "Enter" and "Delete" a few times to reformat every email reply I
  compose.

  I think this is a regression moving to Thunderbird 13.x. I see the
  issue on both Ubuntu 11.10 and 12.04.

  I will try to add some screenshots to demonstrate.

  ProblemType: Bug
  DistroRelease: Ubuntu 11.10
  Package: thunderbird 13.0.1+build1-0ubuntu0.11.10.1
  ProcVersionSignature: Ubuntu 3.0.0-19.33-generic 3.0.27
  Uname: Linux 3.0.0-19-generic x86_64
  NonfreeKernelModules: nvidia
  AddonCompatCheckDisabled: False
  AlsaVersion: Advanced Linux Sound Architecture Driver Version 1.0.24.
  ApportVersion: 1.23-0ubuntu4
  Architecture: amd64
  ArecordDevices:
   **** List of CAPTURE Hardware Devices ****
   card 0: PCH [HDA Intel PCH], device 0: ALC892 Analog [ALC892 Analog]
     Subdevices: 1/1
     Subdevice #0: subdevice #0
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC1:  brian      1767 F.... pulseaudio
   /dev/snd/controlC0:  brian      1767 F.... pulseaudio
  BuildID: 20120615164636
  CRDA: Error: [Errno 2] No such file or directory
  Card0.Amixer.info:
   Card hw:0 'PCH'/'HDA Intel PCH at 0xfa620000 irq 60'
     Mixer name	: 'Realtek ALC892'
     Components	: 'HDA:10ec0892,10438469,00100302'
     Controls      : 35
     Simple ctrls  : 20
  Card1.Amixer.info:
   Card hw:1 'NVidia'/'HDA NVidia at 0xfa080000 irq 17'
     Mixer name	: 'Nvidia GPU 15 HDMI/DP'
     Components	: 'HDA:10de0015,10de0101,00100100'
     Controls      : 16
     Simple ctrls  : 4
  Channel: release
  Date: Fri Jul  6 09:41:05 2012
  ForcedLayersAccel: False
  IfupdownConfig:
   auto lo
   iface lo inet loopback
  InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release amd64 (20110427.1)
  IpRoute:
   default via 192.168.1.1 dev eth0  proto static 
   169.254.0.0/16 dev eth0  scope link  metric 1000 
   192.168.1.0/24 dev eth0  proto kernel  scope link  src 192.168.1.80  metric 1
  IwConfig:
   lo        no wireless extensions.
   
   eth0      no wireless extensions.
  PrefSources:
   /etc/thunderbird/syspref.js
   prefs.js
   user.js
   [Profile]/extensions/{a62ef8ec-5fdc-40c2-873c-223b8a6925cc}/defaults/preferences/preferences.js
   [Profile]/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/defaults/preferences/lightning.js
  Prefs:
   places.database.lastMaintenance: 1336507414 (prefs.js)
   extensions.lastAppVersion: "13.0.1" (prefs.js)
   network.cookie.prefsMigrated: true (prefs.js)
   places.history.expiration.transient_optimal_database_size: 167772160 (prefs.js)
   places.history.expiration.transient_current_max_pages: 104858 (prefs.js)
  Profiles: Profile0 (Default) - LastVersion=13.0.1/20120615164636 (In use)
  RelatedPackageVersions:
   gnome-shell       3.2.2.1-0ubuntu0.1
   rhythmbox-plugins 2.90.1~20110908-0ubuntu1.3
   icedtea-plugin    1.1.3-1ubuntu1.1
   totem-mozilla     3.0.1-0ubuntu7.1
  RfKill:
   0: hci0: Bluetooth
   	Soft blocked: no
   	Hard blocked: no
  RunningIncompatibleAddons: False
  SourcePackage: thunderbird
  UpgradeStatus: Upgraded to oneiric on 2011-11-08 (241 days ago)
  WifiSyslog:
   Jul  6 09:25:52 brian-ubuntu NetworkManager[966]: <info> kernel firmware directory '/lib/firmware' changed
   Jul  6 09:26:34 brian-ubuntu NetworkManager[966]: <info> kernel firmware directory '/lib/firmware' changed
   Jul  6 09:32:16 brian-ubuntu kernel: [589127.615257] gnome-shell[1757]: segfault at 10 ip 00007f605935f0c4 sp 00007fffeedf12f8 error 4 in libnvidia-glcore.so.280.13[7f6058386000+15f4000]
   Jul  6 09:32:48 brian-ubuntu kernel: [589160.172707] SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) thaw-filesystems(J) saK show-backtrace-all-active-cpus(L) show-memory-usage(M) nice-all-RT-tasks(N) powerOff show-registers(P) show-all-timers(Q) unRaw Sync show-task-states(T) Unmount show-blocked-tasks(W) dump-ftrace-buffer(Z) 
   Jul  6 09:32:49 brian-ubuntu kernel: [589161.171764] SysRq : HELP : loglevel(0-9) reBoot Crash terminate-all-tasks(E) memory-full-oom-kill(F) kill-all-tasks(I) thaw-filesystems(J) saK show-backtrace-all-active-cpus(L) show-memory-usage(M) nice-all-RT-tasks(N) powerOff show-registers(P) show-all-timers(Q) unRaw Sync show-task-states(T) Unmount show-blocked-tasks(W) dump-ftrace-buffer(Z)
  dmi.bios.date: 11/22/2011
  dmi.bios.vendor: American Megatrends Inc.
  dmi.bios.version: 2103
  dmi.board.asset.tag: To be filled by O.E.M.
  dmi.board.name: P8P67 PRO
  dmi.board.vendor: ASUSTeK COMPUTER INC.
  dmi.board.version: Rev 1.xx
  dmi.chassis.asset.tag: Asset-1234567890
  dmi.chassis.type: 3
  dmi.chassis.vendor: Chassis Manufacture
  dmi.chassis.version: Chassis Version
  dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvr2103:bd11/22/2011:svnSystemmanufacturer:pnSystemProductName:pvrSystemVersion:rvnASUSTeKCOMPUTERINC.:rnP8P67PRO:rvrRev1.xx:cvnChassisManufacture:ct3:cvrChassisVersion:
  dmi.product.name: System Product Name
  dmi.product.version: System Version
  dmi.sys.vendor: System manufacturer

To manage notifications about this bug go to:
https://bugs.launchpad.net/thunderbird/+bug/1021813/+subscriptions