desktop-packages team mailing list archive

[Bug Watch Updater <1405930@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 32 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1034337.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2014-07-03T22:14:24+00:00 Yuval Adam wrote:

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:30.0) Gecko/20100101 Firefox/30.0 (Beta/Release)
Build ID: 20140605174243

Steps to reproduce:

Go to any input field in the browser (URL bar, search bar, or any input
field on a web page) and type in a mixed English/Hebrew text, or paste
the following example:

abcdefgאבגדהוזחhijkl

Set the cursor on or around the Hebrew text and try to delete characters
using backspace.


Actual results:

It takes two backspace strokes to delete a single character.


Expected results:

Naturally, a single stroke should delete a single character.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/0

------------------------------------------------------------------------
On 2014-07-04T15:56:37+00:00 Alice0775 wrote:

Regressed since Firefox7

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/1

------------------------------------------------------------------------
On 2014-07-04T16:20:42+00:00 Alice0775 wrote:

Regression window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/0c94f01f53af
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110704 Firefox/7.0a1 ID:20110704211816
Bad:
http://hg.mozilla.org/mozilla-central/rev/3f27dc203e62
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:7.0a1) Gecko/20110705 Firefox/7.0a1 ID:20110705030811
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0c94f01f53af&tochange=3f27dc203e62

Regressed by:
3f27dc203e62	Simon Montagu — Undefine caret bidi level during reflow instead of on text entry. Bug 664087, r=roc

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/2

------------------------------------------------------------------------
On 2014-09-14T15:26:04+00:00 Smontagu wrote:

This is really expected behaviour -- if it didn't happen before bug
664087 that was a bug -- but you can change it by setting
bidi.edit.delete_immediately to true in about:config

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/3

------------------------------------------------------------------------
On 2014-09-14T15:27:44+00:00 Smontagu wrote:

See bug 328834 for more info

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/4

------------------------------------------------------------------------
On 2014-09-14T15:29:57+00:00 Yuval Adam wrote:

:smontagu sorry I fail to see how that solves this bug. Out of the box
users who type in Hebrew will need to hit backspace twice to delete. Why
isn't delete_immediately the default behavior?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/5

------------------------------------------------------------------------
On 2014-09-15T05:36:03+00:00 Smontagu wrote:

(In reply to Yuval Adam from comment #5)
> Why isn't
> delete_immediately the default behavior?

Please read bug 328834 for a full explanation. The spec linked to in
that bug doesn't exist at the given URI, but there's a version of it at
http://www.qsm.co.il/Hebrew/logicUI22.htm

That said, I see when experimenting with the testcase on different
builds that what we are doing is not what the spec says: for example the
caret doesn't move at all on the first backspace which undermines a
large part of the rationale for the double backspace. ehsan, what is
your opinion on the debate here and in bug 328834?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/6

------------------------------------------------------------------------
On 2014-09-15T07:49:38+00:00 Smontagu wrote:

*** Bug 1057552 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/7

------------------------------------------------------------------------
On 2014-09-15T07:50:26+00:00 Smontagu wrote:

I am leaning more and more to changing our behaviour here, especially
since we already did so without noticing for some time, and changing
back is perceived by users as a regression (here and in bug 1057552).
Not to mention for interoperability with other browsers and mobile OSs.

There are a number of possibilities:

1) Remove bidi.edit.delete_immediately and the logic handling it
completely.

2) Set bidi.edit.delete_immediately to true by default

3) Set bidi.edit.delete_immediately to true by default on some platforms
(e.g. mobile) only

Any others?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/8

------------------------------------------------------------------------
On 2014-09-15T18:04:36+00:00 Ehsan-mozilla wrote:

I think we should switch bidi.edit.delete_immediately to true by
default.  That seems to be the least surprising UX here.  Our current
behavior is definitely broken.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/9

------------------------------------------------------------------------
On 2014-09-16T07:25:46+00:00 Smontagu wrote:

OK, let's do that. Try push at
https://tbpl.mozilla.org/?tree=Try&rev=fb84895fb960.

I've filed bug 1067788 and bug 1067796 on other issues that I noticed
with the caret in bidi text.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/10

------------------------------------------------------------------------
On 2014-09-16T10:05:28+00:00 Smontagu wrote:

I'm actually pleased that this broke tests, because I suspected that
there weren't any tests for this behaviour :)

The "Tests for bug 419406" in
layout/generic/test/test_backspace_delete.xul need to set
bidi.edit.delete_immediately back to false (or, better, test the
behaviour with both values of the pref).

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/11

------------------------------------------------------------------------
On 2014-09-16T18:33:51+00:00 Ehsan-mozilla wrote:

(In reply to Simon Montagu :smontagu from comment #11)
> I'm actually pleased that this broke tests, because I suspected that there
> weren't any tests for this behaviour :)

Haha, me too!

> The "Tests for bug 419406" in layout/generic/test/test_backspace_delete.xul
> need to set bidi.edit.delete_immediately back to false (or, better, test the
> behaviour with both values of the pref).

Let's do the latter.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/12

------------------------------------------------------------------------
On 2014-09-18T08:44:00+00:00 Smontagu wrote:

Created attachment 8491323
Patch 1: update tests

This tests deletion with the pref set to both true and false, and also
adds a new test so that we are testing Backspace as well as Delete.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/13

------------------------------------------------------------------------
On 2014-09-18T08:45:48+00:00 Smontagu wrote:

Created attachment 8491325
Patch 2: set the pref to true by default

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/14

------------------------------------------------------------------------
On 2014-09-18T08:46:36+00:00 Smontagu wrote:

Try push for those two patches:
https://tbpl.mozilla.org/?tree=Try&rev=0396ebcb7051

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/15

------------------------------------------------------------------------
On 2014-09-19T07:19:55+00:00 Smontagu wrote:

https://hg.mozilla.org/integration/mozilla-inbound/rev/434e148f58c1
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c737d160d5c

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/16

------------------------------------------------------------------------
On 2014-09-19T17:59:09+00:00 Ryanvm wrote:

https://hg.mozilla.org/mozilla-central/rev/434e148f58c1
https://hg.mozilla.org/mozilla-central/rev/8c737d160d5c

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/17

------------------------------------------------------------------------
On 2014-12-13T21:18:53+00:00 Budabass wrote:

Not really sure about the reporting a regression bug in bugzilla, but
this bug reproduced for me after installing Firefox 34.0.5 on Linux Mint
16 (today, Dec 13th 2014).

I used the following method to install the new Firefox version:
http://www.libre-software.net/how-to-install-firefox-on-ubuntu-linux-
mint

As stated previously by Yuval:

Steps to reproduce:
1. Enter Hebrew text in the search bar / URL bar. For example: פיזבאז
2. Press backspace

Actual Result:
For each two backspace keystrokes, one character is deleted.

Expected:
Each keystroke deletes one character,

I switched the bidi.edit.delete_immediately Boolean to True, which
resolved the issue. This should be True by default - if it indeed does
not affect the behavior of other components (everything seems to be
working fine for me after the change, so far.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/18

------------------------------------------------------------------------
On 2014-12-13T21:31:27+00:00 Yuval Adam wrote:

As far as I can tell neither of the patches have actually landed in
Firefox 34. It's unclear to me if they should have or not.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/19

------------------------------------------------------------------------
On 2014-12-15T10:21:26+00:00 Smontagu wrote:

*** Bug 1110135 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/20

------------------------------------------------------------------------
On 2014-12-15T10:21:45+00:00 Smontagu wrote:

*** Bug 1107034 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/21

------------------------------------------------------------------------
On 2014-12-22T18:56:19+00:00 Alireza-fateh wrote:

*** Bug 1114485 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/22

------------------------------------------------------------------------
On 2014-12-24T11:39:11+00:00 Amir-c wrote:

Hi,
Sorry to barge in on this, but

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/23

------------------------------------------------------------------------
On 2014-12-24T11:45:13+00:00 Amir-c wrote:

[sorry about that goof above, couldn't find the delete function]
Hi,
Sorry to barge in on this, but I fail to see the *exact* connection between bidi.edit.delete_immediately and the problem that Yuval Adam has reported.
The way I understand it bidi.edit.delete_immediately is supposed to offer alternate behaviors of backspace when deleting characters _between_ _direction_ _boundraries_. In other words: it's only supposed to affect a backspace key pressed when the text in front of the cursor was written in one direction (say, left-to-right) and the text in rear of the cursor was written in the other direction (say, right-to-left).
In this case the description is of something *else*: when deleting hebrew text, even if there is _no_ change in direction, _every_ character deletion requires _two_ backspace clicks.
Or am I missing something here?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/24

------------------------------------------------------------------------
On 2014-12-24T11:52:35+00:00 Yuval Adam wrote:

(In reply to Amir Meiri from comment #24)
> In this case the description is of something *else*: when deleting hebrew
> text, even if there is _no_ change in direction, _every_ character deletion
> requires _two_ backspace clicks.

Well, clear the URL bar and type a Hebrew string.
If you try to delete from the end of that string indeed you get the double backspace problem.
However, if you move the cursor to the middle of the string, you get proper single backspace behavior.
So, there seems to be an implicit direction change at the end of a bidi string.

In any case, this bug still exists.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/25

------------------------------------------------------------------------
On 2014-12-24T12:11:57+00:00 Smontagu wrote:

(In reply to Amir Meiri from comment #24)
> In this case the description is of something *else*: when deleting hebrew
> text, even if there is _no_ change in direction, _every_ character deletion
> requires _two_ backspace clicks.
> Or am I missing something here?

You're 100% right, that is what Ehsan and I meant above when we agreed
that the current behaviour was broken. The bug still exists only if you
see it in a nightly build, or with bidi.edit.delete_immediately set to
true in about:config

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/26

------------------------------------------------------------------------
On 2014-12-24T12:38:45+00:00 Amir-c wrote:

OK, I see what you mean Yuval. I didn't consider the end-of-line
condition to be a direction switch, but I guess that's potato/potahto.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/27

------------------------------------------------------------------------
On 2015-01-03T13:06:38+00:00 Alice0775 wrote:

*** Bug 1117334 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/38

------------------------------------------------------------------------
On 2015-01-03T13:06:58+00:00 Alice0775 wrote:

*** Bug 1115298 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/39

------------------------------------------------------------------------
On 2015-01-03T13:46:47+00:00 Bahram0110 wrote:

Hello dears
This bug status is resolved
I use latest version of firefox (34.0.5)
It is not resolved yet.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/40

------------------------------------------------------------------------
On 2015-01-03T13:51:06+00:00 Assaf wrote:

I have bidi.edit.delete_immediately set to false and it still happens in the address bar and search inputs, seems resolved in web pages themselves.
FF 34.0.5 latest update.

tried to change it to true it didn't make a difference.

I still need two backspaces to delete one hebrew character in address
bar and search input.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1405930/comments/41


** Changed in: firefox
       Status: Unknown => Fix Released

** Changed in: firefox
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1405930

Title:
  must press backspace twice to delete one Persian/Arabic character

Status in The Mozilla Firefox Browser:
  Fix Released
Status in firefox package in Ubuntu:
  Confirmed

Bug description:
  Ubuntu 14.04
  Firefox 34

  English characters have no problem but when I want to delete a
  Persian/Arabic character I have to press backspace twice to delete
  only one character.

  This bug occurs in text areas where a user can insert text,  for
  instance search bar.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1405930/+subscriptions