desktop-packages team mailing list archive

[Bug Watch Updater <1401402@xxxxxxxxxxxxxxxxxx>]

Launchpad has imported 17 comments from the remote bug at
https://bugzilla.mozilla.org/show_bug.cgi?id=1106854.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2014-12-02T20:43:09+00:00 Horacio wrote:

Created attachment 8531307
Screenshot - 021214 - 17:42:41.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141127111021

Steps to reproduce:

I enabled firefox hello in linux mint 17 - Qiana and tried to import
contacts from Google


Actual results:

A new window opens indicating an error

401. That’s an error.
Error: invalid_client
The OAuth client was not found.
Request Details
    scope=https://www.google.com/m8/feeds
    response_type=code
    redirect_uri=urn:ietf:wg:oauth:2.0:oob:auto
    client_id=no-google-oauth-api-clientid
That’s all we know.


Expected results:

Contacts should be imported from Google.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/0

------------------------------------------------------------------------
On 2014-12-07T19:12:16+00:00 jorgeml wrote:

Same thing for me (Firefox 34.0 with Fedora 21).

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/1

------------------------------------------------------------------------
On 2014-12-08T01:58:34+00:00 jack gurulian wrote:

Same for me on Ubuntu 14.10 / Firefox 34.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/2

------------------------------------------------------------------------
On 2014-12-08T19:02:19+00:00 Adam-nostrum wrote:

This looks like an issue with the downstream OAuth setup. The basic
steps are here: https://wiki.mozilla.org/Loop/OAuth_Setup

Lawrence: do you know who our contacts are at our downstream projects?
We need to reach out to them and let them know about this new
requirement on their builds...

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/3

------------------------------------------------------------------------
On 2014-12-11T02:14:04+00:00 Lmandel wrote:

(In reply to Adam Roach [:abr] from comment #3)
> Lawrence: do you know who our contacts are at our downstream projects? We
> need to reach out to them and let them know about this new requirement on
> their builds...

Lukas - Do you have a list of downstream projects and contacts?
Sylvestre - You're plugged in to some of the Linux distros. Can you help here?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/4

------------------------------------------------------------------------
On 2014-12-11T02:14:42+00:00 Lmandel wrote:

catlee - Does releng maintain a list of downstream projects and do you
have contacts?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/5

------------------------------------------------------------------------
On 2014-12-11T06:59:26+00:00 Eugene Crosser wrote:

I've opened this ticket in Ubuntu:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/7

------------------------------------------------------------------------
On 2014-12-11T08:10:35+00:00 Sledru wrote:

Usually, the way to do that is to update the configure to add a check on this. It will notify packagers about that.
n-i Mike for Debian (and our build system) in case he can help.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/8

------------------------------------------------------------------------
On 2014-12-11T08:32:14+00:00 Mh+mozilla wrote:

Sigh... one more API ID that distros can't use and that breaks
features... We should probably make all the associated flags (not only
this particular one, but all of them) fail to build when building with
--enable-release (which distros should be using)... because failing for
local developers build is not going to pan-out. Then the choice whether
to add an api key or not is in the maintainer's hands, so even if they
decide not use the API key, at least they are aware of it. Although I
could see this as annoying... I don't know.

With my Debian hat on, iirc, most if not all of those API IDs can't be
used in distros because they have to be "hidden". (that's why they're
not in mozilla-central to begin with)

Now, for this specific case, I'd advise removing the import feature
instead of having weird errors when Firefox doesn't have the
corresponding key.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/9

------------------------------------------------------------------------
On 2014-12-11T22:21:48+00:00 Lsblakk wrote:

Afaik there is not a list of downstream projects - would be great to
have one though.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/11

------------------------------------------------------------------------
On 2014-12-11T22:36:44+00:00 Mozilla wrote:

oauth keys are a pain indeed for Linux distributions and in case of
openSUSE cannot added at all since it's not possible to keep the keys
secret as the whole build process and sources are completely open. I
agree with Mike that the feature should be hidden/disabled if no oauth
api keys are configured/built in.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/12

------------------------------------------------------------------------
On 2014-12-11T23:13:36+00:00 Adam-nostrum wrote:

(In reply to Mike Hommey [:glandium] from comment #8)
> Now, for this specific case, I'd advise removing the import feature instead
> of having weird errors when Firefox doesn't have the corresponding key.

I agree that the current behavior isn't okay. I've opened a bug to do
something better, with room to discuss what "better" looks like (Bug
1110508)

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/13

------------------------------------------------------------------------
On 2014-12-11T23:20:45+00:00 Adam-nostrum wrote:

(In reply to Sylvestre Ledru [:sylvestre] from comment #7)
> Usually, the way to do that is to update the configure to add a check on
> this. It will notify packagers about that.

As we were adding this new OAuth key to the build system, we did a lot
of digging around for "what had been done before," including talking to
releng pretty extensively and close examination of similar code landings
(e.g., build system support for our geoloc API key). This didn't come
up.

I know we're not trying to encourage a proliferation of secret material
here, but for those cases in which we don't have a choice (like this
one), it would probably be a Good Thing if we had a wiki page that
captured all the collected lore on Best Current Practices.

Sylvestre: You seem to have some knowledge here. Do you have enough of
an understanding of what Mozilla-specific steps need to take place in
these kinds of cases to take a first stab at such a page? Or were you
speaking about project behavior in general rather than from a Moz
perspective?

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/14

------------------------------------------------------------------------
On 2014-12-12T08:49:50+00:00 Sledru wrote:

I am sorry but I was talking in a more general perspective. However,
Mike, in comment #8, explained that issue.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/15

------------------------------------------------------------------------
On 2014-12-18T20:21:23+00:00 Lmandel wrote:

(In reply to Lukas Blakk [:lsblakk] use ?needinfo from comment #9)
> Afaik there is not a list of downstream projects - would be great to have
> one though.

To follow up on this, I've given myself a Q1 goal to create this list.
If you're redistributing Firefox, please ping me as I'll be collecting
distros and trying to find at least one contact for each.

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/16

------------------------------------------------------------------------
On 2014-12-19T18:13:37+00:00 Sescalante wrote:

requires outreach and private key for contact imports.  will require
working with folks who are just going to be hard to get through
holidays.

will loop back with catlee based on comment

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/17

------------------------------------------------------------------------
On 2015-01-15T12:59:27+00:00 Standard8 wrote:

*** Bug 1121881 has been marked as a duplicate of this bug. ***

Reply at:
https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/1401402/comments/18


** Changed in: firefox
       Status: Unknown => Confirmed

** Changed in: firefox
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to firefox in Ubuntu.
https://bugs.launchpad.net/bugs/1401402

Title:
  Ubuntu build of Firefox lacks Google OAuth ID, prevents contact import
  in Hello

Status in The Mozilla Firefox Browser:
  Confirmed
Status in firefox package in Ubuntu:
  Confirmed

Bug description:
  Starting from verstion 34.0, Firefox, including Ubuntu build thereof, supports WebRTC based voice/video communication feature named "Hello":
  https://support.mozilla.org/en-US/kb/firefox-hello-make-receive-calls-without-account

  This feature works in Ubuntu build, except importing contacts from Google account:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1106854
  Attempt to import contacts results in this Google error page:
  ====
  401. That’s an error.

  Error: invalid_client

  The OAuth client was not found.
  Request Details

      scope=https://www.google.com/m8/feeds
      response_type=code
      redirect_uri=urn:ietf:wg:oauth:2.0:oob:auto
      client_id=no-google-oauth-api-clientid
  ====

  Apparently, for the import feature to work, the build needs to include Google OAuth Client ID. The process is discussed here:
  https://wiki.mozilla.org/Loop/OAuth_Setup

  Apparently, Ubuntu's build of Firefox does not include this Client ID.
  Please consider adding it. Hopefully then "Hello" will be fully functional, including contacts import.

To manage notifications about this bug go to:
https://bugs.launchpad.net/firefox/+bug/1401402/+subscriptions