← Back to team overview

desktop-packages team mailing list archive

[Bug 1190344] Re: lightdm is leaking FDs -fix

 

I needed to run it with sudo.

Every time I switch to Guest Session, logout, and then switch back to
the first user, I notice two more pipes open.

$ sudo lsof -p 1055 | grep FIFO
lsof: WARNING: can't stat() fuse.gvfsd-fuse file system /run/user/1000/gvfs
      Output information may be incomplete.
lightdm 1055 root    4r  FIFO                0,8      0t0   12349 pipe
lightdm 1055 root    5w  FIFO                0,8      0t0   12349 pipe
lightdm 1055 root   13w  FIFO                0,8      0t0   11794 pipe
lightdm 1055 root   14r  FIFO                0,8      0t0   11795 pipe
lightdm 1055 root   15w  FIFO                0,8      0t0   12546 pipe
lightdm 1055 root   16r  FIFO                0,8      0t0   12547 pipe
lightdm 1055 root   18w  FIFO                0,8      0t0 1244475 pipe
lightdm 1055 root   19r  FIFO                0,8      0t0 1244476 pipe
lightdm 1055 root   20w  FIFO                0,8      0t0 1257093 pipe
lightdm 1055 root   21r  FIFO                0,8      0t0 1257094 pipe
lightdm 1055 root   22w  FIFO                0,8      0t0 1316710 pipe
lightdm 1055 root   23r  FIFO                0,8      0t0 1316711 pipe
lightdm 1055 root   24w  FIFO                0,8      0t0 1332415 pipe
lightdm 1055 root   25r  FIFO                0,8      0t0 1332416 pipe
lightdm 1055 root   26w  FIFO                0,8      0t0 1351976 pipe
lightdm 1055 root   27r  FIFO                0,8      0t0 1351977 pipe
lightdm 1055 root   28w  FIFO                0,8      0t0 1369466 pipe
lightdm 1055 root   29r  FIFO                0,8      0t0 1369467 pipe

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to lightdm in Ubuntu.
https://bugs.launchpad.net/bugs/1190344

Title:
  lightdm is leaking FDs -fix

Status in Light Display Manager:
  Fix Released
Status in Light Display Manager 1.10 series:
  Fix Released
Status in Light Display Manager 1.12 series:
  Fix Released
Status in Light Display Manager 1.2 series:
  Fix Released
Status in lightdm package in Ubuntu:
  Fix Released
Status in lightdm source package in Precise:
  Triaged
Status in lightdm source package in Trusty:
  Fix Committed
Status in lightdm source package in Utopic:
  Fix Committed
Status in lightdm source package in Vivid:
  Fix Released
Status in Fedora:
  Unknown

Bug description:
  [Impact]
  LightDM doesn't close the server side end of the pipes used to communicate with session processes. This means each session that is created leaks two file descriptors eventually leading to the system stopping it from creating new pipes.

  [Test Case]
  1. Start LightDM
  2. Check how many pipes are open
  # lsof -p {lightdm_pid} | grep FIFO | wc -l
  3. Create sessions by either cycling between users in Unity Greeter or logging in and out
  4. Check how many pipes exist using step 2.
  Expected result:
  No more pipes should be open
  Observed result:
  Many pipes remain open

  [Regression Potential]
  Low. Fix is to close pipes when finished with them. Tested with regression tests.

To manage notifications about this bug go to:
https://bugs.launchpad.net/lightdm/+bug/1190344/+subscriptions