← Back to team overview

desktop-packages team mailing list archive

[Bug 1411610] Re: don't ignore OobsResult in a callback function

 

Brian, I've changed the description to match SRU Bug Template.

** Description changed:

- The issue with ignoring OobsResult is already fixed in Debian and Ubuntu
- 15.04, but gnome-system-tools remains unpatched in 14.04 and 14.10.
+ [Impact]
  
- The patch is in the attachment. Please add it in 14.04 and 14.10.
+ Users don't receive any info about the errors in the backends (liboobs
+ and system-tools-backends) when they run users-admin tool (unless they
+ run it from the terminal).
  
- Thanks in advance.
+ It's already fixed in Debian and Ubuntu 15.04, but the package remains
+ unpatched in 14.04 and 14.10.
+ 
+ The attached patch makes users-admin show the message dialog with the
+ description of the error that happened.
+ 
+ [Test Case]
+ 
+ You'll need unpatched versions of liboobs (3.0.0-1) and system-tools-backends (2.10.2-1ubuntu1) installed.
+ Run users-admin from the terminal. You'll see a warning message in the terminal:
+ 
+ Liboobs-WARNING **: There was an unknown error communicating
+ asynchronously with the backends: Launch helper exited with unknown
+ return code 255
+ 
+ But the users-admin GUI won't show this message - that's the bug.
+ 
+ [Regression Potential]
+ 
+ I consider the regression risk to be low here. The patch has been
+ already tested by me and gnome-system-tools maintainer in Debian (see
+ the corresponding Debian bug report).

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to gnome-system-tools in Ubuntu.
https://bugs.launchpad.net/bugs/1411610

Title:
  don't ignore OobsResult in a callback function

Status in gnome-system-tools package in Ubuntu:
  Fix Released
Status in gnome-system-tools source package in Trusty:
  Triaged
Status in gnome-system-tools source package in Utopic:
  Triaged
Status in gnome-system-tools package in Debian:
  Fix Released

Bug description:
  [Impact]

  Users don't receive any info about the errors in the backends (liboobs
  and system-tools-backends) when they run users-admin tool (unless they
  run it from the terminal).

  It's already fixed in Debian and Ubuntu 15.04, but the package remains
  unpatched in 14.04 and 14.10.

  The attached patch makes users-admin show the message dialog with the
  description of the error that happened.

  [Test Case]

  You'll need unpatched versions of liboobs (3.0.0-1) and system-tools-backends (2.10.2-1ubuntu1) installed.
  Run users-admin from the terminal. You'll see a warning message in the terminal:

  Liboobs-WARNING **: There was an unknown error communicating
  asynchronously with the backends: Launch helper exited with unknown
  return code 255

  But the users-admin GUI won't show this message - that's the bug.

  [Regression Potential]

  I consider the regression risk to be low here. The patch has been
  already tested by me and gnome-system-tools maintainer in Debian (see
  the corresponding Debian bug report).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gnome-system-tools/+bug/1411610/+subscriptions


References