desktop-packages team mailing list archive
-
desktop-packages team
-
Mailing list archive
-
Message #97205
[Bug 1411584] Re: correctly return error and emit warning
** Branch linked: lp:ubuntu/trusty-proposed/liboobs
** Branch linked: lp:~ubuntu-branches/ubuntu/utopic/liboobs/utopic-
proposed
--
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to liboobs in Ubuntu.
https://bugs.launchpad.net/bugs/1411584
Title:
correctly return error and emit warning
Status in liboobs package in Ubuntu:
Fix Released
Status in liboobs source package in Trusty:
Fix Committed
Status in liboobs source package in Utopic:
Fix Committed
Status in liboobs package in Debian:
Fix Released
Bug description:
[Impact]
When a user tries to change his full name via users-admin or mate-
users-admin, and some error happens in the backends (either liboobs or
system-tools-backends), the error message isn't shown in the GUI.
Moreover, the new full name will appear in the GUI, as if it has been
successfully changed (when it's not so).
The issues are already fixed in Debian and Ubuntu 15.04, but the
package remains unpatched in 14.04 and 14.10.
The attached patches make users-admin (and mate-users-admin) show the
error message dialog when the mentioned error happens, and also show
the unchanged full name in this case.
[Test Case]
You'll need the unpatched version of system-tools-backends (2.10.2-1ubuntu1) installed.
Run users-admin or mate-users-admin from the terminal. Click on the button for changing your full name, change the name to something else and click "OK".
You'll see a warning message in the terminal:
Liboobs-WARNING **: There was an unknown error communicating with the
backends: Launch helper exited with unknown return code 255
No error message dialog will appear though.
Also the full name in the GUI will be changed to the name you entered. This is not correct because some error happened in the backends, and the name hasn't been actually changed. You can see that for yourself by simply restarting users-admin or mate-users-admin - it will show the old name then.
[Regression Potential]
I consider the regression risk to be low here. The patches have been
already tested by me and liboobs maintainer in Debian (see the
corresponding Debian bug report).
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/liboobs/+bug/1411584/+subscriptions
References