← Back to team overview

desktop-packages team mailing list archive

[Bug 1101413] Re: Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test-privatescreen.cpp - in function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody() - No check of the return value of "option.set(value)".

 

** Changed in: compiz
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to compiz in Ubuntu.
https://bugs.launchpad.net/bugs/1101413

Title:
  Coverity CHECKED_RETURN - CID 12406 - src/privatescreen/tests/test-
  privatescreen.cpp - in function:
  privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody()
  - No check of the return value of "option.set(value)".

Status in Compiz:
  Fix Released
Status in Compiz 0.9.9 series:
  Won't Fix
Status in compiz package in Ubuntu:
  Fix Released

Bug description:
  This bug is exported from the Coverity Integration Manager on Canonical's servers. For information on how this is done please see this website: https://wiki.ubuntu.com/CanonicalProductStrategy/Coverity
  CID: 12406
  Checker: CHECKED_RETURN
  Category: No category available
  CWE definition: http://cwe.mitre.org/data/definitions/252.html
  File: /tmp/buildd/compiz-0.9.9~daily13.01.14/src/privatescreen/tests/test-privatescreen.cpp
  Function: privatescreen_ButtonPressEdgeEventManagementTest_NoTriggerOnUnboundAction_Test::TestBody()
  Code snippet:
  1239     MockTriggerableAction triggerableAction;
  1240     ce::EventArguments    arguments;
  1241     int                   edgeMask = 1 << SCREEN_EDGE_TOP;
  1242 
  CID 12406 - CHECKED_RETURN
  Calling function "CompOption::set(CompOption::Value &)" without checking return value (as is done elsewhere 1171 out of 1219 times).
  No check of the return value of "option.set(value)".
  1243     option.set (value);
  1244 
  1245     const ce::ActionModsMatchesEventStateFunc &matchEventState =
  1246 	    GetMatchEventStateFuncForMock (triggerableAction);
  1247 
  1248     EXPECT_FALSE (ce::activateButtonPressOnEdgeBindingOption (option,

To manage notifications about this bug go to:
https://bugs.launchpad.net/compiz/+bug/1101413/+subscriptions