← Back to team overview

desktop-packages team mailing list archive

[Bug 1173727] Re: exo-open does not handle URIs properly

 

Launchpad has imported 3 comments from the remote bug at
https://bugzilla.xfce.org/show_bug.cgi?id=10098.

If you reply to an imported comment from within Launchpad, your comment
will be sent to the remote bug automatically. Read more about
Launchpad's inter-bugtracker facilities at
https://help.launchpad.net/InterBugTracking.

------------------------------------------------------------------------
On 2013-05-19T04:13:54+00:00 Felipe Contreras wrote:

Created attachment 5040
string: fix exo_str_looks_like_an_uri()

Commit d11199b (Check if uris also contain a slash (bug #9244)) tried to
fix a hang in thunar by properly recognizing that 'http:' is not an URI,
however, while doing so, it broke proper URIs like 'magnet:foo'.

As the RFC clearly states:

   The following are two example URIs and their component parts:

         foo://example.com:8042/over/there?name=ferret#nose
         \_/   \______________/\_________/ \_________/ \__/
          |           |            |            |        |
       scheme     authority       path        query   fragment
          |   _____________________|__
         / \ /                        \
         urn:example:animal:ferret:nose

But even with this succinct example exo_str_looks_like_an_uri() fails.

There is an easy solution; fail only when component part is missing
('urn:'), but succeed otherwise.

This solution fixes 'magnet:foo', and doesn't break the current
expectation from thunar that 'http:' should fail, having the best of
both worlds.

[1] http://www.ietf.org/rfc/rfc3986.txt

See bugs:
https://bugzilla.xfce.org/show_bug.cgi?id=9597
https://bugzilla.xfce.org/show_bug.cgi?id=9647
https://bugzilla.xfce.org/show_bug.cgi?id=9244

Reply at: https://bugs.launchpad.net/ubuntu/+source/xdg-
utils/+bug/1173727/comments/3

------------------------------------------------------------------------
On 2013-05-19T12:46:26+00:00 8-nick wrote:

Applied in 05848bb.

Reply at: https://bugs.launchpad.net/ubuntu/+source/xdg-
utils/+bug/1173727/comments/4

------------------------------------------------------------------------
On 2013-05-19T12:47:49+00:00 8-nick wrote:

*** Bug 9597 has been marked as a duplicate of this bug. ***

Reply at: https://bugs.launchpad.net/ubuntu/+source/xdg-
utils/+bug/1173727/comments/5


** Changed in: exo
       Status: Unknown => Fix Released

** Changed in: exo
   Importance: Unknown => High

** Bug watch added: Xfce Bugzilla #9647
   https://bugzilla.xfce.org/show_bug.cgi?id=9647

** Bug watch added: Xfce Bugzilla #9244
   https://bugzilla.xfce.org/show_bug.cgi?id=9244

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xdg-utils in Ubuntu.
https://bugs.launchpad.net/bugs/1173727

Title:
  exo-open does not handle URIs properly

Status in exo:
  Fix Released
Status in exo package in Ubuntu:
  Confirmed
Status in xdg-utils package in Ubuntu:
  Invalid

Bug description:
  when executing xdg-open "magnet:?...

  xdg-open detects XFCE display manager and calls exo-open "$1" witch is
  not capable to handle magnets at all.

  should it call gnome-open with xubuntu?

  quick fix:

  edit /usr/bin/xdg-open and change
  if [ x"$DE" = x"" ]; then
      DE=generic
  fi

  to
  if [ x"$DE" = x"" ]; then
      DE=generic
  fi
  DE=gnome

  ProblemType: Bug
  DistroRelease: Ubuntu 13.04
  Package: xdg-utils 1.1.0~rc1-2ubuntu7
  ProcVersionSignature: Ubuntu 3.8.0-19.29-generic 3.8.8
  Uname: Linux 3.8.0-19-generic x86_64
  NonfreeKernelModules: fglrx
  ApportVersion: 2.9.2-0ubuntu8
  Architecture: amd64
  Date: Sat Apr 27 22:08:40 2013
  InstallationDate: Installed on 2013-04-11 (16 days ago)
  InstallationMedia: Xubuntu 12.04.2 LTS "Precise Pangolin" - Release amd64 (20130213)
  MarkForUpload: True
  PackageArchitecture: all
  SourcePackage: xdg-utils
  UpgradeStatus: Upgraded to raring on 2013-04-25 (1 days ago)

To manage notifications about this bug go to:
https://bugs.launchpad.net/exo/+bug/1173727/+subscriptions