← Back to team overview

desktop-packages team mailing list archive

[Bug 1220426]

 

Yeah, it should.  Thanks for the ping.

Marking fixed with commit fe4c774c572e3f55a7417f0ca336ae1479a966ad
Author: Nikhil Mahale <nmahale@xxxxxxxxxx>
Date:   Sat Jan 24 17:06:59 2015 -0800

    os: Fix timer race conditions
    
    Fixing following kind of race-conditions -
    
        WaitForSomething()
        |
        ---->  // timers -> timer-1 -> timer-2 -> null
               while (timers && (int) (timers->expires - now) <= 0)
                   // prototype - DoTimer(OsTimerPtr timer, CARD32 now, OsTimerPtr *prev)
                   DoTimer(timers, now, &timers)
                   |
                   |
                   ----> OsBlockSignals();  .... OS Signal comes just before blocking it,
                                            .... timer-1 handler gets called.
                                                 // timer-1 gets served and scheduled again;
                                                 // timers -> timer-2 -> timer-1 -> null
                                            ....
                         *prev = timer->next;
                          timer->next = NULL;   // timers -> null
                          // timers list gets corrupted here and timer-2 gets removed from list.
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=86288
    Signed-off-by: Nikhil Mahale <nmahale@xxxxxxxxxx>
    Reviewed-by: Julien Cristau <jcristau@xxxxxxxxxx>
    
    v2: Apply warning fixes from Keith Packard <keithp@xxxxxxxxxx>
    
    Reviewed-by: Aaron Plattner <aplattner@xxxxxxxxxx>
    Signed-off-by: Aaron Plattner <aplattner@xxxxxxxxxx>
    Signed-off-by: Keith Packard <keithp@xxxxxxxxxx>

 os/WaitFor.c | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

-- 
You received this bug notification because you are a member of Desktop
Packages, which is subscribed to xorg-server in Ubuntu.
https://bugs.launchpad.net/bugs/1220426

Title:
  [nvidia-prime]Freeze while using touchpad

Status in X.Org X server:
  Fix Released
Status in xorg-server package in Ubuntu:
  Triaged

Bug description:
  Using Asus N43SL laptop as an example, with nvidia-prime installed, so
  the dedicated NVIDIA graphics card (GT 540m) is in use, once in a
  while, my screen will freeze when I use my touchpad.

  WORKAROUND: Use USB mouse.

  WORKAROUND: Uninstall nvidia-prime and use integrated graphics.

  WORKAROUND: Do a VT switch via Ctrl+Alt+F1 then Ctrl+Alt+F7.

  In the attached Xorg.0.log, you can see "synaptics: ETPS/2 Elantech Touchpad: touchpad found" each time I did a VT switch and regained control:
  https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/1220426/+attachment/3801516/+files/Xorg.0.log

  The following upstream report has a patch that addresses this issue:
  https://bugs.freedesktop.org/show_bug.cgi?id=86288

To manage notifications about this bug go to:
https://bugs.launchpad.net/xorg-server/+bug/1220426/+subscriptions