dhis2-devs-core team mailing list archive

[Morten Olav Hansen <mortenoh@xxxxxxxxx>]

Just a quick not Tran, enum values are always in uppercase (they are
constants)

+    aggregate( "aggregate" ), tracker( "tracker" );

Should be

+    AGGREGATE( "aggregate" ), TRACKER( "tracker" );

--
Morten


On Sun, Jun 15, 2014 at 3:28 PM, Tran Chau <tran.hispvietnam@xxxxxxxxx>
wrote:

> Hi all,
>
> I finished to rename the Patient domain type to tracker by using Enum.
> Please take a look at it in revision 15686.
>
> Thank you.
>
> Best regards,
> ------------------------------------------------
> Châu Thu Trân
> HISP Viet Nam
> Email: tran.hispvietnam@xxxxxxxxx
>
>
> On Sun, Jun 15, 2014 at 9:27 AM, Tran Chau <tran.hispvietnam@xxxxxxxxx>
> wrote:
>
>> Hi all,
>>
>> I am working on it now.
>>
>> Best regards,
>> ------------------------------------------------
>> Châu Thu Trân
>> HISP Viet Nam
>> Email: tran.hispvietnam@xxxxxxxxx
>>
>>
>> On Fri, Jun 13, 2014 at 2:49 AM, Lars Helge Øverland <larshelge@xxxxxxxxx
>> > wrote:
>>
>>> Yes we can do that since we are changing in any case.
>>>
>>>
>>> On Thu, Jun 12, 2014 at 8:02 PM, Morten Olav Hansen <mortenoh@xxxxxxxxx>
>>> wrote:
>>>
>>>> Could I suggest using a enum for this. I want us to move that way going
>>>> forward, since it makes it easier to auto-generate lists of possible
>>>> choices for a certain property (which is more or less impossible using
>>>> these final constants).
>>>>
>>>> --
>>>> Morten
>>>>
>>>>
>>>> On Thu, Jun 12, 2014 at 7:58 PM, Lars Helge Øverland <
>>>> larshelge@xxxxxxxxx> wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> we need to change the data element domain type from "patient" to
>>>>> "tracker". This includes finals on DataElement.java and data element vm
>>>>> template.
>>>>>
>>>>> *Tran* could you please do this? This must be tested extensively -
>>>>> please take your time and test well. You can use grep (install gow
>>>>> <https://github.com/bmatzelle/gow/archive/master.zip> on windows) to
>>>>> search for use in javascript/vm templates.
>>>>>
>>>>> If *anyone* sees any places where this will break current
>>>>> functionality please update after the change has been done.
>>>>>
>>>>> Lars
>>>>>
>>>>> --
>>>>> Mailing list: https://launchpad.net/~dhis2-devs-core
>>>>> Post to     : dhis2-devs-core@xxxxxxxxxxxxxxxxxxx
>>>>> Unsubscribe : https://launchpad.net/~dhis2-devs-core
>>>>> More help   : https://help.launchpad.net/ListHelp
>>>>>
>>>>>
>>>>
>>>
>>
>